Re: [Qemu-devel] [PATCH] iothread: fix iothread hang when stop too soon

2019-01-29 Thread Stefan Hajnoczi
On Tue, Jan 29, 2019 at 01:14:32PM +0800, Peter Xu wrote: > Lukas reported an hard to reproduce QMP iothread hang on s390 that > QEMU might hang at pthread_join() of the QMP monitor iothread before > quitting: > > Thread 1 > #0 0x03ffad10932c in pthread_join > #1 0x000109e95750 in

Re: [Qemu-devel] [PATCH] iothread: fix iothread hang when stop too soon

2019-01-29 Thread Peter Xu
On Tue, Jan 29, 2019 at 05:20:40PM +0100, Markus Armbruster wrote: > Marc-André (cc'ed) recently fixed a deadlock (commit 34f1f3e06d8 > "monitor: avoid potential dead-lock when cleaning up"). Looks like we > got more. Yes, and a few tests too. Hopefully these fallouts can settle soon before the

Re: [Qemu-devel] [PATCH] iothread: fix iothread hang when stop too soon

2019-01-29 Thread Peter Xu
On Tue, Jan 29, 2019 at 03:44:05PM +0100, Thomas Huth wrote: [...] > I ran this on s390x with Lukáš' reproducer for a while now, and so far I > haven't seen any hangs anymore. Thus this seems to fix the issue as far > as I can see, thanks! > > Tested-by: Thomas Huth Thanks for the quick follow

Re: [Qemu-devel] [PATCH] iothread: fix iothread hang when stop too soon

2019-01-29 Thread Markus Armbruster
Marc-André (cc'ed) recently fixed a deadlock (commit 34f1f3e06d8 "monitor: avoid potential dead-lock when cleaning up"). Looks like we got more. Peter Xu writes: > Lukas reported an hard to reproduce QMP iothread hang on s390 that > QEMU might hang at pthread_join() of the QMP monitor iothread

Re: [Qemu-devel] [PATCH] iothread: fix iothread hang when stop too soon

2019-01-29 Thread Thomas Huth
On 2019-01-29 06:14, Peter Xu wrote: > Lukas reported an hard to reproduce QMP iothread hang on s390 that > QEMU might hang at pthread_join() of the QMP monitor iothread before > quitting: > > Thread 1 > #0 0x03ffad10932c in pthread_join > #1 0x000109e95750 in qemu_thread_join >

[Qemu-devel] [PATCH] iothread: fix iothread hang when stop too soon

2019-01-28 Thread Peter Xu
Lukas reported an hard to reproduce QMP iothread hang on s390 that QEMU might hang at pthread_join() of the QMP monitor iothread before quitting: Thread 1 #0 0x03ffad10932c in pthread_join #1 0x000109e95750 in qemu_thread_join at /home/thuth/devel/qemu/util/qemu-thread-posix.