Re: [Qemu-devel] [PATCH] io: Improve websocket support by becoming more RFC compliant.

2017-07-25 Thread Brandon Carpenter
Sure thing. I implemented it in multiple commits, but there was enough overlap in those commits that I thought it would require extra unnecessary work to review. But I also found an issue that needs fixed, so I need to resubmit anyway. -- Brandon Carpenter | Software Engineer Cypherpath, Inc.

Re: [Qemu-devel] [PATCH] io: Improve websocket support by becoming more RFC compliant.

2017-07-25 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 11:42:17AM -0700, Brandon Carpenter wrote: > Remembering the opcode is sufficient for handling fragmented frames from > the client, which may be introduced by an intermediary server/proxy. > Respond to pings and ignore pongs rather than close the connection as > many browser

[Qemu-devel] [PATCH] io: Improve websocket support by becoming more RFC compliant.

2017-07-24 Thread Brandon Carpenter
Remembering the opcode is sufficient for handling fragmented frames from the client, which may be introduced by an intermediary server/proxy. Respond to pings and ignore pongs rather than close the connection as many browsers use ping/pong to test an idle connection. Close connections according to