Re: [Qemu-devel] [PATCH] include: Make headers more self-contained

2019-07-15 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/15/19 1:39 PM, Markus Armbruster wrote: >> Back in 2016, we discussed[1] rules for headers, and these were >> generally liked: >> >> 1. Have a carefully curated header that's included everywhere first. We >>got that already thanks to Peter: osdep.h. >>

Re: [Qemu-devel] [PATCH] include: Make headers more self-contained

2019-07-15 Thread Philippe Mathieu-Daudé
On 7/15/19 1:39 PM, Markus Armbruster wrote: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers should normally include eve

[Qemu-devel] [PATCH] include: Make headers more self-contained

2019-07-15 Thread Markus Armbruster
Back in 2016, we discussed[1] rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are need