Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread John Snow
On 09/15/2015 02:50 PM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 02:11 PM, Markus Armbruster wrote: >>> John Snow writes: >>> On 09/15/2015 02:53 AM, Markus Armbruster wrote: > John Snow writes: > >> We're a little too lenient with what we'll let an ATA

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread Markus Armbruster
John Snow writes: > On 09/15/2015 02:11 PM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 09/15/2015 02:53 AM, Markus Armbruster wrote: John Snow writes: > We're a little too lenient with what we'll let an ATAPI drive handle. > Clamp down on the IDE command executio

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread John Snow
On 09/15/2015 02:11 PM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 02:53 AM, Markus Armbruster wrote: >>> John Snow writes: >>> We're a little too lenient with what we'll let an ATAPI drive handle. Clamp down on the IDE command execution table to remove CD_OK per

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread Markus Armbruster
John Snow writes: > On 09/15/2015 02:53 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> We're a little too lenient with what we'll let an ATAPI drive handle. >>> Clamp down on the IDE command execution table to remove CD_OK permissions >>> from commands that are not and have never been

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread John Snow
On 09/15/2015 02:53 AM, Markus Armbruster wrote: > John Snow writes: > >> We're a little too lenient with what we'll let an ATAPI drive handle. >> Clamp down on the IDE command execution table to remove CD_OK permissions >> from commands that are not and have never been ATAPI commands. >> >> Fo

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread Kevin Wolf
Am 14.09.2015 um 20:49 hat John Snow geschrieben: > On 09/14/2015 02:43 PM, Michael Tokarev wrote: > > 14.09.2015 21:04, John Snow wrote: > >> On 09/11/2015 02:56 AM, Michael Tokarev wrote: > >>> 09.09.2015 19:28, John Snow wrote: > We're a little too lenient with what we'll let an ATAPI drive

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-14 Thread Markus Armbruster
John Snow writes: > We're a little too lenient with what we'll let an ATAPI drive handle. > Clamp down on the IDE command execution table to remove CD_OK permissions > from commands that are not and have never been ATAPI commands. > > For ATAPI command validity, please see: > - ATA4 Section 6.5 (

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-14 Thread John Snow
On 09/14/2015 02:43 PM, Michael Tokarev wrote: > 14.09.2015 21:04, John Snow wrote: >> On 09/11/2015 02:56 AM, Michael Tokarev wrote: >>> 09.09.2015 19:28, John Snow wrote: We're a little too lenient with what we'll let an ATAPI drive handle. Clamp down on the IDE command execution tabl

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-14 Thread Michael Tokarev
14.09.2015 21:04, John Snow wrote: > On 09/11/2015 02:56 AM, Michael Tokarev wrote: >> 09.09.2015 19:28, John Snow wrote: >>> We're a little too lenient with what we'll let an ATAPI drive handle. >>> Clamp down on the IDE command execution table to remove CD_OK permissions >>> from commands that ar

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-14 Thread John Snow
On 09/11/2015 02:56 AM, Michael Tokarev wrote: > 09.09.2015 19:28, John Snow wrote: >> We're a little too lenient with what we'll let an ATAPI drive handle. >> Clamp down on the IDE command execution table to remove CD_OK permissions >> from commands that are not and have never been ATAPI command

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-10 Thread Michael Tokarev
09.09.2015 19:28, John Snow wrote: > We're a little too lenient with what we'll let an ATAPI drive handle. > Clamp down on the IDE command execution table to remove CD_OK permissions > from commands that are not and have never been ATAPI commands. FWIW, this issue has been assigned CVE-2015-6855 i

[Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-09 Thread John Snow
We're a little too lenient with what we'll let an ATAPI drive handle. Clamp down on the IDE command execution table to remove CD_OK permissions from commands that are not and have never been ATAPI commands. For ATAPI command validity, please see: - ATA4 Section 6.5 ("PACKET Command feature set") -