Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Kevin Wolf
Am 28.05.2013 um 11:48 hat Paolo Bonzini geschrieben: > Il 28/05/2013 11:36, Kevin Wolf ha scritto: > > Am 28.05.2013 um 11:24 hat Paolo Bonzini geschrieben: > >> Il 28/05/2013 11:18, Kevin Wolf ha scritto: > > The other part why I haven't sent a fix yet is that I don't have a test > > case

Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Paolo Bonzini
Il 28/05/2013 11:36, Kevin Wolf ha scritto: > Am 28.05.2013 um 11:24 hat Paolo Bonzini geschrieben: >> Il 28/05/2013 11:18, Kevin Wolf ha scritto: > The other part why I haven't sent a fix yet is that I don't have a test > case for it. Temporarily add a sleep(31) in qemu_fdatasync

Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Kevin Wolf
Am 28.05.2013 um 11:24 hat Paolo Bonzini geschrieben: > Il 28/05/2013 11:18, Kevin Wolf ha scritto: > >>> The other part why I haven't sent a fix yet is that I don't have a test > >>> case for it. > >> > >> Temporarily add a sleep(31) in qemu_fdatasync()? > >> > >> I was lazy in testing with -snaps

Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Paolo Bonzini
Il 28/05/2013 11:18, Kevin Wolf ha scritto: >>> The other part why I haven't sent a fix yet is that I don't have a test >>> case for it. >> >> Temporarily add a sleep(31) in qemu_fdatasync()? >> >> I was lazy in testing with -snapshot to not corrupt my disk image, which >> would not trigger the sam

Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Kevin Wolf
Am 28.05.2013 um 10:46 hat Andreas Färber geschrieben: > Am 28.05.2013 10:27, schrieb Kevin Wolf: > > Am 28.05.2013 um 10:18 hat Andreas Färber geschrieben: > >> The implementation of the ATA FLUSH command invokes a flush at the block > >> layer, which may on raw files on POSIX entail a synchronous

Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Andreas Färber
Am 28.05.2013 10:27, schrieb Kevin Wolf: > Am 28.05.2013 um 10:18 hat Andreas Färber geschrieben: >> The implementation of the ATA FLUSH command invokes a flush at the block >> layer, which may on raw files on POSIX entail a synchronous fdatasync(). >> This may in some cases take so long that the S

Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Kevin Wolf
Am 28.05.2013 um 10:18 hat Andreas Färber geschrieben: > The implementation of the ATA FLUSH command invokes a flush at the block > layer, which may on raw files on POSIX entail a synchronous fdatasync(). > This may in some cases take so long that the SLES 11 SP1 guest driver > reports I/O errors a

[Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Andreas Färber
The implementation of the ATA FLUSH command invokes a flush at the block layer, which may on raw files on POSIX entail a synchronous fdatasync(). This may in some cases take so long that the SLES 11 SP1 guest driver reports I/O errors and filesystems get corrupted or remounted read-only. Avoid thi