Re: [Qemu-devel] [PATCH] ide: Correct the CHS 'cyls_max' limit to be 65535

2016-01-19 Thread John Snow
On 01/18/2016 05:19 AM, Shmulik Ladkani wrote: > In b7eb0c9: > hw/block-common: Factor out fall back to legacy -drive cyls=... > 'blkconf_geometry()' was introduced, factoring out CHS limit validation > code that was repeated in ide, scsi, virtio-blk. > > The original IDE CHS limit prior b7eb0

[Qemu-devel] [PATCH] ide: Correct the CHS 'cyls_max' limit to be 65535

2016-01-18 Thread Shmulik Ladkani
In b7eb0c9: hw/block-common: Factor out fall back to legacy -drive cyls=... 'blkconf_geometry()' was introduced, factoring out CHS limit validation code that was repeated in ide, scsi, virtio-blk. The original IDE CHS limit prior b7eb0c9 was 65535,16,255 (as per ATA CHS addressing). However the