Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution v2

2011-09-01 Thread Paolo Bonzini
On 08/31/2011 11:06 PM, Lucas Meneghel Rodrigues wrote: +CharDriverState *chr; I think it's unused, no? Paolo

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution v2

2011-09-01 Thread Jan Kiszka
On 2011-08-31 23:06, Lucas Meneghel Rodrigues wrote: > Add a test device which supports the kvmctl ioports, > for running the KVM test suite. > > Usage: > > qemu > -chardev file,path=/log/file/some/where,id=testlog > -device pc-testdev,chardev=testlog > > lmr: I've tried to address t

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution v2

2011-08-31 Thread Edgar E. Iglesias
On Wed, Aug 31, 2011 at 06:06:09PM -0300, Lucas Meneghel Rodrigues wrote: > Add a test device which supports the kvmctl ioports, > for running the KVM test suite. > > Usage: > > qemu > -chardev file,path=/log/file/some/where,id=testlog > -device pc-testdev,chardev=testlog > > lmr: I'

[Qemu-devel] [PATCH] hw: Add test device for unittests execution v2

2011-08-31 Thread Lucas Meneghel Rodrigues
Add a test device which supports the kvmctl ioports, for running the KVM test suite. Usage: qemu -chardev file,path=/log/file/some/where,id=testlog -device pc-testdev,chardev=testlog lmr: I've tried to address the comments made by the reviewers, but I probably left out some things. P