Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2012-10-04 Thread Paolo Bonzini
Il 04/10/2012 10:02, Peter Maydell ha scritto: > On 4 October 2012 04:49, Lucas Meneghel Rodrigues wrote: >> Add a test device which supports the kvmctl ioports, >> so one can run the KVM unittest suite [1]. >> >> Usage: >> >> qemu -device testdev >> >> 1) Removed port 0xf1, since now kvm-unit-tes

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2012-10-04 Thread Peter Maydell
On 4 October 2012 04:49, Lucas Meneghel Rodrigues wrote: > Add a test device which supports the kvmctl ioports, > so one can run the KVM unittest suite [1]. > > Usage: > > qemu -device testdev > > 1) Removed port 0xf1, since now kvm-unit-tests use >serial > > 2) Removed exit code port 0xf4, si

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2012-10-04 Thread Paolo Bonzini
Il 04/10/2012 05:49, Lucas Meneghel Rodrigues ha scritto: > Add a test device which supports the kvmctl ioports, > so one can run the KVM unittest suite [1]. > > Usage: > > qemu -device testdev > > 1) Removed port 0xf1, since now kvm-unit-tests use >serial > > 2) Removed exit code port 0xf4

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2012-10-03 Thread Lucas Meneghel Rodrigues
On 10/04/2012 12:49 AM, Lucas Meneghel Rodrigues wrote: Add a test device which supports the kvmctl ioports, so one can run the KVM unittest suite [1]. Usage: qemu -device testdev 1) Removed port 0xf1, since now kvm-unit-tests use serial 2) Removed exit code port 0xf4, since that can be

[Qemu-devel] [PATCH] hw: Add test device for unittests execution

2012-10-03 Thread Lucas Meneghel Rodrigues
Add a test device which supports the kvmctl ioports, so one can run the KVM unittest suite [1]. Usage: qemu -device testdev 1) Removed port 0xf1, since now kvm-unit-tests use serial 2) Removed exit code port 0xf4, since that can be replaced by -device isa-debugexit,iobase=0xf4,access-siz

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution v2

2011-09-01 Thread Paolo Bonzini
On 08/31/2011 11:06 PM, Lucas Meneghel Rodrigues wrote: +CharDriverState *chr; I think it's unused, no? Paolo

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution v2

2011-09-01 Thread Jan Kiszka
On 2011-08-31 23:06, Lucas Meneghel Rodrigues wrote: > Add a test device which supports the kvmctl ioports, > for running the KVM test suite. > > Usage: > > qemu > -chardev file,path=/log/file/some/where,id=testlog > -device pc-testdev,chardev=testlog > > lmr: I've tried to address t

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution v2

2011-08-31 Thread Edgar E. Iglesias
On Wed, Aug 31, 2011 at 06:06:09PM -0300, Lucas Meneghel Rodrigues wrote: > Add a test device which supports the kvmctl ioports, > for running the KVM test suite. > > Usage: > > qemu > -chardev file,path=/log/file/some/where,id=testlog > -device pc-testdev,chardev=testlog > > lmr: I'

[Qemu-devel] [PATCH] hw: Add test device for unittests execution v2

2011-08-31 Thread Lucas Meneghel Rodrigues
Add a test device which supports the kvmctl ioports, for running the KVM test suite. Usage: qemu -chardev file,path=/log/file/some/where,id=testlog -device pc-testdev,chardev=testlog lmr: I've tried to address the comments made by the reviewers, but I probably left out some things. P

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-30 Thread Lluís
Blue Swirl writes: > On Tue, Aug 30, 2011 at 7:36 PM, Lluís wrote: >> Blue Swirl writes: >> >>> Even better, taking the instrumentation approach, could the test >>> device be left out completely, just use guest invisible methods (like >>> watchpoints) to interact with the guest? >> >> I don't g

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-30 Thread Blue Swirl
On Tue, Aug 30, 2011 at 7:36 PM, Lluís wrote: > Blue Swirl writes: > >> Even better, taking the instrumentation approach, could the test >> device be left out completely, just use guest invisible methods (like >> watchpoints) to interact with the guest? > > I don't get it. Sorry but I've not been

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-30 Thread Lluís
Blue Swirl writes: > Even better, taking the instrumentation approach, could the test > device be left out completely, just use guest invisible methods (like > watchpoints) to interact with the guest? I don't get it. Sorry but I've not been closely following the thread, and a quick look at it gav

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-30 Thread Blue Swirl
On Mon, Aug 29, 2011 at 5:57 AM, Avi Kivity wrote: > On 08/27/2011 07:22 PM, Blue Swirl wrote: >> >> >  + >> >  +static void test_device_irq_line(void *opaque, uint32_t addr, uint32_t >> > data) >> >  +{ >> >  +    qemu_set_irq(isa_get_irq(addr - 0x2000), !!data); >> >> Where does 0x2000 come from

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-29 Thread Lucas Meneghel Rodrigues
On 08/26/2011 06:22 PM, Anthony Liguori wrote: On 08/26/2011 03:04 PM, Lucas Meneghel Rodrigues wrote: Add a test device which supports the kvmctl ioports, for running the KVM test suite. This is a straight port from the latest version of the test device present on qemu-kvm, using the APIs curre

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-28 Thread Avi Kivity
On 08/27/2011 07:22 PM, Blue Swirl wrote: > + > +static void test_device_irq_line(void *opaque, uint32_t addr, uint32_t data) > +{ > +qemu_set_irq(isa_get_irq(addr - 0x2000), !!data); Where does 0x2000 come from? The base address of this range. > + > +static uint32_t test_iomem_rea

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-28 Thread Avi Kivity
On 08/27/2011 01:26 AM, Jan Kiszka wrote: > + > +static void test_device_irq_line(void *opaque, uint32_t addr, uint32_t data) > +{ > +qemu_set_irq(isa_get_irq(addr - 0x2000), !!data); Note that qemu-kvm retrieves (due to a hack) GSIs via isa_get_irq while QEMU is and will remain confined

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-28 Thread Avi Kivity
On 08/27/2011 01:07 PM, Edgar E. Iglesias wrote: > >+ > >+static ISADeviceInfo testdev_info = { > >+.qdev.name = "testdev", > >+.qdev.size = sizeof(struct testdev), > >+.init = init_test_device, > >+.qdev.props = (Property[]) { > >+DEFINE_PROP_CHR("chardev",

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-28 Thread Avi Kivity
On 08/27/2011 12:22 AM, Anthony Liguori wrote: I think I posted patches at some point for kvm unittests to use a standard UART. Was there any reason not to do use a UART? No. +static void test_device_exit(void *opaque, uint32_t addr, uint32_t data) +{ +exit(data); +} Port 501 can

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-27 Thread Blue Swirl
On Sat, Aug 27, 2011 at 10:07 AM, Edgar E. Iglesias wrote: > On Fri, Aug 26, 2011 at 04:22:22PM -0500, Anthony Liguori wrote: >> On 08/26/2011 03:04 PM, Lucas Meneghel Rodrigues wrote: >> >Add a test device which supports the kvmctl ioports, >> >for running the KVM test suite. This is a straight >

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-27 Thread Blue Swirl
On Fri, Aug 26, 2011 at 8:04 PM, Lucas Meneghel Rodrigues wrote: > Add a test device which supports the kvmctl ioports, > for running the KVM test suite. This is a straight > port from the latest version of the test device present > on qemu-kvm, using the APIs currently in use by qemu. Or rather

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-27 Thread Edgar E. Iglesias
On Fri, Aug 26, 2011 at 04:22:22PM -0500, Anthony Liguori wrote: > On 08/26/2011 03:04 PM, Lucas Meneghel Rodrigues wrote: > >Add a test device which supports the kvmctl ioports, > >for running the KVM test suite. This is a straight > >port from the latest version of the test device present > >on q

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-26 Thread Jan Kiszka
On 2011-08-26 22:04, Lucas Meneghel Rodrigues wrote: > Add a test device which supports the kvmctl ioports, > for running the KVM test suite. This is a straight > port from the latest version of the test device present > on qemu-kvm, using the APIs currently in use by qemu. > > With this we aim fo

Re: [Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-26 Thread Anthony Liguori
On 08/26/2011 03:04 PM, Lucas Meneghel Rodrigues wrote: Add a test device which supports the kvmctl ioports, for running the KVM test suite. This is a straight port from the latest version of the test device present on qemu-kvm, using the APIs currently in use by qemu. With this we aim for daily

[Qemu-devel] [PATCH] hw: Add test device for unittests execution

2011-08-26 Thread Lucas Meneghel Rodrigues
Add a test device which supports the kvmctl ioports, for running the KVM test suite. This is a straight port from the latest version of the test device present on qemu-kvm, using the APIs currently in use by qemu. With this we aim for daily execution of the KVM unittests to capture any problems wi