Re: [Qemu-devel] [PATCH] hw/usb/bus.c: print device ID when 'info usb' used

2015-08-28 Thread Programmingkid
On Aug 28, 2015, at 12:07 PM, Peter Maydell wrote: > On 28 August 2015 at 14:55, Programmingkid wrote: >> On Aug 28, 2015, at 9:50 AM, Gerd Hoffmann wrote: >>> Even better: Don't print "ID: ..." in the first place in case it is not >>> present. >> >> The ID is printed so if the user needs to re

Re: [Qemu-devel] [PATCH] hw/usb/bus.c: print device ID when 'info usb' used

2015-08-28 Thread Peter Maydell
On 28 August 2015 at 14:55, Programmingkid wrote: > On Aug 28, 2015, at 9:50 AM, Gerd Hoffmann wrote: >> Even better: Don't print "ID: ..." in the first place in case it is not >> present. > > The ID is printed so if the user needs to remove the device, device_del > can be used. > > If the ID is

Re: [Qemu-devel] [PATCH] hw/usb/bus.c: print device ID when 'info usb' used

2015-08-28 Thread Programmingkid
On Aug 28, 2015, at 9:50 AM, Gerd Hoffmann wrote: > On Fr, 2015-08-28 at 09:39 -0400, Programmingkid wrote: >> On Aug 28, 2015, at 9:35 AM, Daniel P. Berrange wrote: >> >>> On Fri, Aug 28, 2015 at 09:08:12AM -0400, Programmingkid wrote: On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote

Re: [Qemu-devel] [PATCH] hw/usb/bus.c: print device ID when 'info usb' used

2015-08-28 Thread Gerd Hoffmann
On Fr, 2015-08-28 at 09:39 -0400, Programmingkid wrote: > On Aug 28, 2015, at 9:35 AM, Daniel P. Berrange wrote: > > > On Fri, Aug 28, 2015 at 09:08:12AM -0400, Programmingkid wrote: > >> > >> On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote: > >> > >>> On Mo, 2015-08-24 at 15:13 -0400, Programm

Re: [Qemu-devel] [PATCH] hw/usb/bus.c: print device ID when 'info usb' used

2015-08-28 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 09:39:43AM -0400, Programmingkid wrote: > > On Aug 28, 2015, at 9:35 AM, Daniel P. Berrange wrote: > > > On Fri, Aug 28, 2015 at 09:08:12AM -0400, Programmingkid wrote: > >> > >> On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote: > >> > >>> On Mo, 2015-08-24 at 15:13 -040

Re: [Qemu-devel] [PATCH] hw/usb/bus.c: print device ID when 'info usb' used

2015-08-28 Thread Programmingkid
On Aug 28, 2015, at 9:35 AM, Daniel P. Berrange wrote: > On Fri, Aug 28, 2015 at 09:08:12AM -0400, Programmingkid wrote: >> >> On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote: >> >>> On Mo, 2015-08-24 at 15:13 -0400, Programmingkid wrote: +monitor_printf(mon, " Device %d.%d,

Re: [Qemu-devel] [PATCH] hw/usb/bus.c: print device ID when 'info usb' used

2015-08-28 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 09:08:12AM -0400, Programmingkid wrote: > > On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote: > > > On Mo, 2015-08-24 at 15:13 -0400, Programmingkid wrote: > >> +monitor_printf(mon, " Device %d.%d, Port %s, Speed %s > >> Mb/s," > >> +

Re: [Qemu-devel] [PATCH] hw/usb/bus.c: print device ID when 'info usb' used

2015-08-28 Thread Programmingkid
On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote: > On Mo, 2015-08-24 at 15:13 -0400, Programmingkid wrote: >> +monitor_printf(mon, " Device %d.%d, Port %s, Speed %s >> Mb/s," >> +"Product %s, ID %s\n", >> + bus->busnr, dev->a

Re: [Qemu-devel] [PATCH] hw/usb/bus.c: print device ID when 'info usb' used

2015-08-28 Thread Gerd Hoffmann
On Mo, 2015-08-24 at 15:13 -0400, Programmingkid wrote: > +monitor_printf(mon, " Device %d.%d, Port %s, Speed %s > Mb/s," > +"Product %s, ID %s\n", > + bus->busnr, dev->addr, port->path, > + usb_speed(d

[Qemu-devel] [PATCH] hw/usb/bus.c: print device ID when 'info usb' used

2015-08-24 Thread Programmingkid
Print the ID of each device when 'info usb' is used in the monitor. Signed-off-by: John Arbuckle --- This patch is easier to test when the qdev-monitor.c patch I also submitted is applied first. It can still be tested without it. Just run QEMU with the -usb option. Then go to the monitor and typ