Re: [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw

2013-12-25 Thread Li Guang
Peter Maydell wrote: On 26 December 2013 00:22, Li Guang wrote: Peter Maydell wrote: On 25 December 2013 07:21, liguang wrote: This is where your patch should have had an explanation for why you're making this change. What is the user outside of hw/sd/ that needs this header that m

Re: [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw

2013-12-25 Thread Peter Maydell
On 26 December 2013 00:22, Li Guang wrote: > Peter Maydell wrote: >> On 25 December 2013 07:21, liguang wrote: >> This is where your patch should have had an explanation >> for why you're making this change. What is the user outside >> of hw/sd/ that needs this header that means we should >> move

Re: [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw

2013-12-25 Thread Li Guang
Peter Maydell wrote: On 25 December 2013 07:21, liguang wrote: This is where your patch should have had an explanation for why you're making this change. What is the user outside of hw/sd/ that needs this header that means we should move it into include/ ? I don't mean someone will inclu

Re: [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw

2013-12-25 Thread Peter Maydell
On 25 December 2013 07:21, liguang wrote: This is where your patch should have had an explanation for why you're making this change. What is the user outside of hw/sd/ that needs this header that means we should move it into include/ ? > Signed-off-by: liguang thanks -- PMM

[Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw

2013-12-24 Thread liguang
Signed-off-by: liguang --- hw/sd/sdhci.c |2 +- hw/sd/sdhci.h | 312 include/hw/sdhci.h | 312 3 files changed, 313 insertions(+), 313 deletions(-) delete mode 100644 hw/sd/s