Re: [Qemu-devel] [PATCH] hw/scsi-bus.c: Fix use of uninitialised variable

2011-08-14 Thread Blue Swirl
Thanks, applied. On Fri, Aug 12, 2011 at 4:49 PM, Peter Maydell wrote: > Don't use req before it has been initialised in scsi_req_new(). > This fixes a compile failure due to gcc complaining about this. > > Signed-off-by: Peter Maydell > --- >  hw/scsi-bus.c |    2 +- >  1 files changed, 1 inser

Re: [Qemu-devel] [PATCH] hw/scsi-bus.c: Fix use of uninitialised variable

2011-08-14 Thread Paolo Bonzini
On 08/12/2011 06:49 PM, Peter Maydell wrote: Don't use req before it has been initialised in scsi_req_new(). This fixes a compile failure due to gcc complaining about this. Signed-off-by: Peter Maydell --- hw/scsi-bus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH] hw/scsi-bus.c: Fix use of uninitialised variable

2011-08-14 Thread Paolo Bonzini
On 08/13/2011 07:29 PM, Blue Swirl wrote: On Fri, Aug 12, 2011 at 7:22 PM, Blue Swirl wrote: On Fri, Aug 12, 2011 at 4:49 PM, Peter Maydell wrote: Don't use req before it has been initialised in scsi_req_new(). This fixes a compile failure due to gcc complaining about this. It fixes a crash

Re: [Qemu-devel] [PATCH] hw/scsi-bus.c: Fix use of uninitialised variable

2011-08-13 Thread Blue Swirl
On Fri, Aug 12, 2011 at 7:22 PM, Blue Swirl wrote: > On Fri, Aug 12, 2011 at 4:49 PM, Peter Maydell > wrote: >> Don't use req before it has been initialised in scsi_req_new(). >> This fixes a compile failure due to gcc complaining about this. > > It fixes a crash if the warning is ignored: > Con

Re: [Qemu-devel] [PATCH] hw/scsi-bus.c: Fix use of uninitialised variable

2011-08-12 Thread Blue Swirl
On Fri, Aug 12, 2011 at 4:49 PM, Peter Maydell wrote: > Don't use req before it has been initialised in scsi_req_new(). > This fixes a compile failure due to gcc complaining about this. It fixes a crash if the warning is ignored: Configuration device id QEMU version 1 machine id 32 Program recei

[Qemu-devel] [PATCH] hw/scsi-bus.c: Fix use of uninitialised variable

2011-08-12 Thread Peter Maydell
Don't use req before it has been initialised in scsi_req_new(). This fixes a compile failure due to gcc complaining about this. Signed-off-by: Peter Maydell --- hw/scsi-bus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index f2af6cd..55