On 11 November 2011 21:05, andrzej zaborowski wrote:
>>> - s->pm_regs[addr>> 2]&= 0x15& ~(value& 0x2a);
>>> + /* Clear the write-one-to-clear bits... */
>>> + s->pm_regs[addr>> 2]&= ~(value& 0x2a);
>>> + /* ...and set the plain r/w bits */
>>> s->pm_regs[a
Hi,
On 11 November 2011 20:45, Anthony Liguori wrote:
> On 11/09/2011 02:46 PM, Peter Maydell wrote:
>>
>> Fix a bug in handling the write-one-to-clear bits in the PMCR
>> which meant that we would always clear the bit even if the
>> value written was a zero. Spotted by Coverity (see bug 887883).
On 11/09/2011 02:46 PM, Peter Maydell wrote:
Fix a bug in handling the write-one-to-clear bits in the PMCR
which meant that we would always clear the bit even if the
value written was a zero. Spotted by Coverity (see bug 887883).
Signed-off-by: Peter Maydell
Applied. Thanks.
Regards,
Anthon
Fix a bug in handling the write-one-to-clear bits in the PMCR
which meant that we would always clear the bit even if the
value written was a zero. Spotted by Coverity (see bug 887883).
Signed-off-by: Peter Maydell
---
hw/pxa2xx.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
dif