Re: [Qemu-devel] [PATCH] hw/pci: Add e1000e NIC as command line argument

2017-10-16 Thread Lukas Humbel
On 16.10.2017 19:02, Michael S. Tsirkin wrote: > On Mon, Oct 16, 2017 at 06:03:36PM +0200, lukas.hum...@inf.ethz.ch wrote: >> From: Lukas Humbel >> >> Signed-off-by: Lukas Humbel > We keep these around for legacy reasons but I'm not sure we need to add > to the list. What's wrong with just crea

Re: [Qemu-devel] [PATCH] hw/pci: Add e1000e NIC as command line argument

2017-10-16 Thread Michael S. Tsirkin
On Mon, Oct 16, 2017 at 06:03:36PM +0200, lukas.hum...@inf.ethz.ch wrote: > From: Lukas Humbel > > Signed-off-by: Lukas Humbel We keep these around for legacy reasons but I'm not sure we need to add to the list. What's wrong with just creating them with -device e1000e? > --- > hw/pci/pci.c |

[Qemu-devel] [PATCH] hw/pci: Add e1000e NIC as command line argument

2017-10-16 Thread lukas.humbel
From: Lukas Humbel Signed-off-by: Lukas Humbel --- hw/pci/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 1e6fb88..9d6cd04 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1819,6 +1819,7 @@ static const char * const pci_nic_models[] = { "i82559