Re: [Qemu-devel] [PATCH] hw/i2c: QOM'ify i2c slave

2018-01-14 Thread Philippe Mathieu-Daudé
On 01/14/2018 12:34 PM, Peter Maydell wrote: > On 14 January 2018 at 02:45, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/i2c/core.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/hw/i2c/core.c b/hw/i2c/core.c >> ind

Re: [Qemu-devel] [PATCH] hw/i2c: QOM'ify i2c slave

2018-01-14 Thread Peter Maydell
On 14 January 2018 at 02:45, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i2c/core.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hw/i2c/core.c b/hw/i2c/core.c > index 59068f157e..c84dbfb884 100644 > --- a/hw/i2c/core.c

Re: [Qemu-devel] [PATCH] hw/i2c: QOM'ify i2c slave

2018-01-13 Thread Philippe Mathieu-Daudé
This description is more appropriate: "hw/i2c: convert i2c slave init() to realize()" On 01/13/2018 11:45 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i2c/core.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hw/i2c/

[Qemu-devel] [PATCH] hw/i2c: QOM'ify i2c slave

2018-01-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/i2c/core.c b/hw/i2c/core.c index 59068f157e..c84dbfb884 100644 --- a/hw/i2c/core.c +++ b/hw/i2c/core.c @@ -8,6 +8,7 @@ */ #include "qemu/osdep.h" +#incl