Re: [Qemu-devel] [PATCH] hw/display: QOM'ify g364fb.c

2017-01-05 Thread 赵小强
在 2017年1月5日,23:10,Peter Maydell 写道: >> sysbus_init_irq(sbd, &s->irq); >>sysbus_init_mmio(sbd, &s->mem_ctrl); >>sysbus_init_mmio(sbd, &s->mem_vram); > > This means we call sysbus_init_mmio() on the MemoryRegion*s > before we have initialized them. That seems like a bad idea. Opps,will

Re: [Qemu-devel] [PATCH] hw/display: QOM'ify g364fb.c

2017-01-05 Thread Peter Maydell
On 25 December 2016 at 08:25, xiaoqiang zhao wrote: > Drop the old Sysbus init and use instance_init and > DeviceClass::realize instead > > Signed-off-by: xiaoqiang zhao > --- > hw/display/g364fb.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/hw/disp

[Qemu-devel] [PATCH] hw/display: QOM'ify g364fb.c

2016-12-25 Thread xiaoqiang zhao
Drop the old Sysbus init and use instance_init and DeviceClass::realize instead Signed-off-by: xiaoqiang zhao --- hw/display/g364fb.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c index 70ef2c7453..7a0fe48dd5 10064