Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-21 Thread BALATON Zoltan
On Thu, 21 Feb 2019, Gerd Hoffmann wrote: On Thu, Feb 21, 2019 at 12:44:22PM +0100, BALATON Zoltan wrote: On Wed, 20 Feb 2019, Gerd Hoffmann wrote: So it could be tested with linux guests on x86 too I guess? Can the radeon drm driver handle the devices too? Yes you can try with x86 guests, I

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-21 Thread Gerd Hoffmann
On Thu, Feb 21, 2019 at 12:44:22PM +0100, BALATON Zoltan wrote: > On Wed, 20 Feb 2019, Gerd Hoffmann wrote: > > > > So it could be tested with linux guests on x86 too I guess? > > > > Can the radeon drm driver handle the devices too? > > > > > > Yes you can try with x86 guests, I haven't tested th

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-21 Thread BALATON Zoltan
On Wed, 20 Feb 2019, Gerd Hoffmann wrote: So it could be tested with linux guests on x86 too I guess? Can the radeon drm driver handle the devices too? Yes you can try with x86 guests, I haven't tested that yet. The radeon driver only supports RV100 and up I think so may only work with the 0x51

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-21 Thread Peter Maydell
On Thu, 21 Feb 2019 at 00:51, BALATON Zoltan wrote: > > On Thu, 21 Feb 2019, BALATON Zoltan wrote: > > On Tue, 19 Feb 2019, Peter Maydell wrote: > >> On Tue, 12 Feb 2019 at 23:59, BALATON Zoltan wrote: > >>> On Tue, 12 Feb 2019, Philippe Mathieu-Daudé wrote: > I'd have use a pair of extract3

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-20 Thread BALATON Zoltan
On Thu, 21 Feb 2019, BALATON Zoltan wrote: On Tue, 19 Feb 2019, Peter Maydell wrote: On Tue, 12 Feb 2019 at 23:59, BALATON Zoltan wrote: On Tue, 12 Feb 2019, Philippe Mathieu-Daudé wrote: I'd have use a pair of extract32/deposit32 but this is probably easier By the way, should these lines i

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-20 Thread BALATON Zoltan
On Tue, 19 Feb 2019, Peter Maydell wrote: On Tue, 12 Feb 2019 at 23:59, BALATON Zoltan wrote: On Tue, 12 Feb 2019, Philippe Mathieu-Daudé wrote: On 2/11/19 4:19 AM, BALATON Zoltan wrote: This is where my question about valid/impl on mem ops started but I asked separately again after not get

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-20 Thread BALATON Zoltan
Hello, On Wed, 20 Feb 2019, Gerd Hoffmann wrote: So it could be tested with linux guests on x86 too I guess? Can the radeon drm driver handle the devices too? Yes you can try with x86 guests, I haven't tested that yet. The radeon driver only supports RV100 and up I think so may only work with

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread Gerd Hoffmann
Hi, > > So it could be tested with linux guests on x86 too I guess? > > Can the radeon drm driver handle the devices too? > > Yes you can try with x86 guests, I haven't tested that yet. The radeon > driver only supports RV100 and up I think so may only work with the 0x5159 > variant not with Ra

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread BALATON Zoltan
On Tue, 19 Feb 2019, Gerd Hoffmann wrote: Which linux driver is this? Those in linux/drivers/video/fbdev/aty/. This ati-vga model defaults to Rage 128 Pro (what PoweMac3,1 has, device id 0x5046) which is handled by the aty128fb driver under Linux. MIPS fulong2e has Mobility Radeon M6 (RV100, de

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread Gerd Hoffmann
Hi, > > Which linux driver is this? > > Those in linux/drivers/video/fbdev/aty/. This ati-vga model defaults to Rage > 128 Pro (what PoweMac3,1 has, device id 0x5046) which is handled by the > aty128fb driver under Linux. MIPS fulong2e has Mobility Radeon M6 (RV100, > device id 0x5159) that you

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread BALATON Zoltan
On Tue, 19 Feb 2019, Peter Maydell wrote: On Tue, 12 Feb 2019 at 23:59, BALATON Zoltan wrote: On Tue, 12 Feb 2019, Philippe Mathieu-Daudé wrote: On 2/11/19 4:19 AM, BALATON Zoltan wrote: [...] + +static void ati_reg_write_offs(uint32_t *reg, int offs, + uint64_t

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread BALATON Zoltan
On Tue, 19 Feb 2019, Gerd Hoffmann wrote: On Mon, Feb 11, 2019 at 04:19:14AM +0100, BALATON Zoltan wrote: At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and guests running on these and the PMON2000 firmware of the

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread Peter Maydell
On Tue, 12 Feb 2019 at 23:59, BALATON Zoltan wrote: > > Hello, > > On Tue, 12 Feb 2019, Philippe Mathieu-Daudé wrote: > > Hi Zoltan, > > Thanks for the quick review and testing. I'll use your suggestions for the > other (mips) patches in a v2. For this one I'm not convinced. > > > On 2/11/19 4:19

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-19 Thread Gerd Hoffmann
On Mon, Feb 11, 2019 at 04:19:14AM +0100, BALATON Zoltan wrote: > At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI > gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and > guests running on these and the PMON2000 firmware of the fulong2e > expect this to be available.

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-13 Thread BALATON Zoltan
Hello, On Wed, 13 Feb 2019, Mark Cave-Ayland wrote: On 12/02/2019 23:59, BALATON Zoltan wrote: This looks interesting, however I never received the original via the mailing list. Did it get held somewhere because its size? It appears in the list archives: http://lists.nongnu.org/archive/html/

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-12 Thread Mark Cave-Ayland
On 12/02/2019 23:59, BALATON Zoltan wrote: > Hello, > > On Tue, 12 Feb 2019, Philippe Mathieu-Daudé wrote: >> Hi Zoltan, > > Thanks for the quick review and testing. I'll use your suggestions for the > other > (mips) patches in a v2. For this one I'm not convinced. > >> On 2/11/19 4:19 AM, BAL

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-12 Thread BALATON Zoltan
Hello, On Tue, 12 Feb 2019, Philippe Mathieu-Daudé wrote: Hi Zoltan, Thanks for the quick review and testing. I'll use your suggestions for the other (mips) patches in a v2. For this one I'm not convinced. On 2/11/19 4:19 AM, BALATON Zoltan wrote: [...] + +static void ati_reg_write_offs(

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-11 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 2/11/19 4:19 AM, BALATON Zoltan wrote: > At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI > gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and > guests running on these and the PMON2000 firmware of the fulong2e > expect this to be available. Fortunate

[Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-10 Thread BALATON Zoltan
At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and guests running on these and the PMON2000 firmware of the fulong2e expect this to be available. Fortunately these are very similar chips so they can be mostly emulated