Re: [Qemu-devel] [PATCH] hw/arm/virt: Initialize NICs configured in PCI bus

2016-01-11 Thread Peter Maydell
On 11 January 2016 at 02:54, Jason Wang wrote: > > > On 01/07/2016 11:21 PM, Paolo Bonzini wrote: >> >> On 07/01/2016 15:47, Peter Maydell wrote: >>> I think my current inclination is to say that virt should >>> support -net, because I would prefer to avoid having yet >>> another speedbump in the

Re: [Qemu-devel] [PATCH] hw/arm/virt: Initialize NICs configured in PCI bus

2016-01-10 Thread Jason Wang
On 01/07/2016 11:21 PM, Paolo Bonzini wrote: > > On 07/01/2016 15:47, Peter Maydell wrote: >> I think my current inclination is to say that virt should >> support -net, because I would prefer to avoid having yet >> another speedbump in the path of people trying to move to >> using KVM-on-ARM base

Re: [Qemu-devel] [PATCH] hw/arm/virt: Initialize NICs configured in PCI bus

2016-01-07 Thread Paolo Bonzini
On 07/01/2016 15:47, Peter Maydell wrote: > I think my current inclination is to say that virt should > support -net, because I would prefer to avoid having yet > another speedbump in the path of people trying to move to > using KVM-on-ARM based on their previous experience with > KVM-on-x86. I

Re: [Qemu-devel] [PATCH] hw/arm/virt: Initialize NICs configured in PCI bus

2016-01-07 Thread Peter Maydell
On 7 January 2016 at 05:53, Ashok Kumar wrote: > On Wed, Jan 06, 2016 at 06:10:15PM +, Peter Maydell wrote: >> I guess from the patch that this is adding support for >> the legacy '-net' way of configuring networking, but do >> we need that if we never supported it in the first place? >> (If v

Re: [Qemu-devel] [PATCH] hw/arm/virt: Initialize NICs configured in PCI bus

2016-01-06 Thread Ashok Kumar
On Wed, Jan 06, 2016 at 06:10:15PM +, Peter Maydell wrote: Hi, > On 6 January 2016 at 14:47, Ashok Kumar wrote: > > virtio model is used for default case. > > > > Signed-off-by: Ashok Kumar > > Could you explain why you think this needs to be done? Yes, for -net. Honestly, I didn't know thi

Re: [Qemu-devel] [PATCH] hw/arm/virt: Initialize NICs configured in PCI bus

2016-01-06 Thread Peter Maydell
On 6 January 2016 at 14:47, Ashok Kumar wrote: > virtio model is used for default case. > > Signed-off-by: Ashok Kumar Could you explain why you think this needs to be done? Virtio networking works OK for me... I guess from the patch that this is adding support for the legacy '-net' way of conf

[Qemu-devel] [PATCH] hw/arm/virt: Initialize NICs configured in PCI bus

2016-01-06 Thread Ashok Kumar
virtio model is used for default case. Signed-off-by: Ashok Kumar --- hw/arm/virt.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index acc1fcb..fd52b76 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -808,6 +808,7 @@ static void create_pcie(