Re: [Qemu-devel] [PATCH] hw/arm/pxa2xx_gpio: Correct and register vmstate

2014-06-04 Thread Peter Maydell
On 4 June 2014 13:28, Peter Crosthwaite wrote: > On Wed, Jun 4, 2014 at 4:58 AM, Peter Maydell > wrote: >> On 3 June 2014 19:30, Peter Maydell wrote: >>> The pxa2xx-gpio device has a VMStateDescription, but it was accidentally >>> never actually registered, and it wasn't quite correct. Remove t

Re: [Qemu-devel] [PATCH] hw/arm/pxa2xx_gpio: Correct and register vmstate

2014-06-04 Thread Peter Crosthwaite
On Wed, Jun 4, 2014 at 4:58 AM, Peter Maydell wrote: > On 3 June 2014 19:30, Peter Maydell wrote: >> The pxa2xx-gpio device has a VMStateDescription, but it was accidentally >> never actually registered, and it wasn't quite correct. Remove the >> 'lines' field (this is a device property, not muta

Re: [Qemu-devel] [PATCH] hw/arm/pxa2xx_gpio: Correct and register vmstate

2014-06-03 Thread Peter Maydell
On 3 June 2014 19:30, Peter Maydell wrote: > The pxa2xx-gpio device has a VMStateDescription, but it was accidentally > never actually registered, and it wasn't quite correct. Remove the > 'lines' field (this is a device property, not mutable state), add > the missing 'gpsr' and 'prev_level' field

[Qemu-devel] [PATCH] hw/arm/pxa2xx_gpio: Correct and register vmstate

2014-06-03 Thread Peter Maydell
The pxa2xx-gpio device has a VMStateDescription, but it was accidentally never actually registered, and it wasn't quite correct. Remove the 'lines' field (this is a device property, not mutable state), add the missing 'gpsr' and 'prev_level' fields, and set dc->vmsd so it actually gets used. Signe