Re: [Qemu-devel] [PATCH] hw/arm/exynos4210: fix Exynos4210 UART support

2018-09-25 Thread Peter Maydell
On 31 August 2018 at 11:23, Bartlomiej Zolnierkiewicz wrote: > commit 97274d0c05d4 ("hw/char/exynos4210_uart.c: Remove unneeded > handling of NULL chardev") broke Exynos4210 support as it removed > NULL 'Chardev *chr' handling from exynos4210_uart_create() and > currently exynos4210_init() always

Re: [Qemu-devel] [PATCH] hw/arm/exynos4210: fix Exynos4210 UART support

2018-09-07 Thread Philippe Mathieu-Daudé
On 8/31/18 7:23 AM, Bartlomiej Zolnierkiewicz wrote: > commit 97274d0c05d4 ("hw/char/exynos4210_uart.c: Remove unneeded > handling of NULL chardev") broke Exynos4210 support as it removed > NULL 'Chardev *chr' handling from exynos4210_uart_create() and > currently exynos4210_init() always passes NU

[Qemu-devel] [PATCH] hw/arm/exynos4210: fix Exynos4210 UART support

2018-08-31 Thread Bartlomiej Zolnierkiewicz
commit 97274d0c05d4 ("hw/char/exynos4210_uart.c: Remove unneeded handling of NULL chardev") broke Exynos4210 support as it removed NULL 'Chardev *chr' handling from exynos4210_uart_create() and currently exynos4210_init() always passes NULL as 'Chardev *chr' argument to exynos4210_uart_create() cal

Re: [Qemu-devel] [PATCH] hw/arm/exynos4210: fix Exynos4210 UART support

2018-08-31 Thread Thomas Huth
On 2018-08-31 12:23, Bartlomiej Zolnierkiewicz wrote: > commit 97274d0c05d4 ("hw/char/exynos4210_uart.c: Remove unneeded > handling of NULL chardev") broke Exynos4210 support as it removed > NULL 'Chardev *chr' handling from exynos4210_uart_create() and > currently exynos4210_init() always passes N