Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

2015-12-21 Thread Eric Blake
On 12/18/2015 12:55 PM, Markus Armbruster wrote: > Alberto Garcia writes: > > We do however have translations for a few simple strings for the GTK+ > menu items, so in order to run QEMU using the C locale, and yet have a > translated UI let's use setlocale() for LC_MESSAGES only.

Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

2015-12-18 Thread Markus Armbruster
Alberto Garcia writes: >>> > We do however have translations for a few simple strings for the GTK+ >>> > menu items, so in order to run QEMU using the C locale, and yet have a >>> > translated UI let's use setlocale() for LC_MESSAGES only. >>> > >>> Not sure why I noticed it only now and if it's

Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

2015-12-18 Thread Alberto Garcia
>> > We do however have translations for a few simple strings for the GTK+ >> > menu items, so in order to run QEMU using the C locale, and yet have a >> > translated UI let's use setlocale() for LC_MESSAGES only. >> > >> Not sure why I noticed it only now and if it's related to any recent >> pac

Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

2015-12-18 Thread Kevin Wolf
Am 18.12.2015 um 14:23 hat Gerd Hoffmann geschrieben: > On Fr, 2015-12-18 at 12:38 +0100, Kevin Wolf wrote: > > Am 10.09.2015 um 17:19 hat Alberto Garcia geschrieben: > > > The QEMU code is not internationalized and assumes that it runs under > > > the C locale, but if we use the GTK+ UI we'll end

Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

2015-12-18 Thread Gerd Hoffmann
On Fr, 2015-12-18 at 12:38 +0100, Kevin Wolf wrote: > Am 10.09.2015 um 17:19 hat Alberto Garcia geschrieben: > > The QEMU code is not internationalized and assumes that it runs under > > the C locale, but if we use the GTK+ UI we'll end up importing the > > locale settings from the environment. Thi

Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

2015-12-18 Thread Kevin Wolf
Am 10.09.2015 um 17:19 hat Alberto Garcia geschrieben: > The QEMU code is not internationalized and assumes that it runs under > the C locale, but if we use the GTK+ UI we'll end up importing the > locale settings from the environment. This can break things, such as > the JSON generator and iotest

Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

2015-09-11 Thread Gerd Hoffmann
> void early_gtk_display_init(int opengl) > { > +/* The QEMU code relies on the assumption that it's always run in > + * the C locale. Therefore it is not prepared to deal with > + * operations that produce different results depending on the > + * locale, such as printf's formatti

[Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

2015-09-10 Thread Alberto Garcia
The QEMU code is not internationalized and assumes that it runs under the C locale, but if we use the GTK+ UI we'll end up importing the locale settings from the environment. This can break things, such as the JSON generator and iotest 120 in locales that use a decimal comma. We do however have tr