Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation

2014-11-28 Thread Markus Armbruster
Ekaterina Tumanova writes: > Signed-off-by: Ekaterina Tumanova > --- > hw/block/hd-geometry.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/block/hd-geometry.c b/hw/block/hd-geometry.c > index b462225..905d2c6 100644 > --- a/hw/block/hd-geometry.c > +++ b/hw/

Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation

2014-11-21 Thread Ekaterina Tumanova
On 11/20/2014 07:18 PM, Kevin Wolf wrote: Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben: On Wed, 19 Nov 2014 14:40:07 + Peter Maydell wrote: On 19 November 2014 14:01, Ekaterina Tumanova wrote: Signed-off-by: Ekaterina Tumanova Could you give the compiler error/warning message

Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation

2014-11-20 Thread Christian Borntraeger
Am 20.11.2014 um 17:18 schrieb Kevin Wolf: > Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben: >> On Wed, 19 Nov 2014 14:40:07 + >> Peter Maydell wrote: >> >>> On 19 November 2014 14:01, Ekaterina Tumanova >>> wrote: Signed-off-by: Ekaterina Tumanova >>> >>> Could you give the compi

Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation

2014-11-20 Thread Kevin Wolf
Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben: > On Wed, 19 Nov 2014 14:40:07 + > Peter Maydell wrote: > > > On 19 November 2014 14:01, Ekaterina Tumanova > > wrote: > > > Signed-off-by: Ekaterina Tumanova > > > > Could you give the compiler error/warning message, please > > (and th

Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation

2014-11-19 Thread Cornelia Huck
On Wed, 19 Nov 2014 14:40:07 + Peter Maydell wrote: > On 19 November 2014 14:01, Ekaterina Tumanova > wrote: > > Signed-off-by: Ekaterina Tumanova > > Could you give the compiler error/warning message, please > (and the compiler version)? > > These changes look sensible but it's not clear

Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation

2014-11-19 Thread Peter Maydell
On 19 November 2014 14:01, Ekaterina Tumanova wrote: > Signed-off-by: Ekaterina Tumanova Could you give the compiler error/warning message, please (and the compiler version)? These changes look sensible but it's not clear to me why the current code would cause a compilation failure or why that

[Qemu-devel] [PATCH] geometry: fix i386 compilation

2014-11-19 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova --- hw/block/hd-geometry.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/block/hd-geometry.c b/hw/block/hd-geometry.c index b462225..905d2c6 100644 --- a/hw/block/hd-geometry.c +++ b/hw/block/hd-geometry.c @@ -147,7 +147,8 @@ void h