Re: [Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2013-01-24 Thread Jan Kiszka
On 2013-01-24 12:19, Fabien Chouteau wrote: > On 01/24/2013 03:02 AM, Joel Brobecker wrote: >>> qAttached is not supported in Qemu yet, this explains why Gdb sends >>> "kill" at the end of debug session. I will implement it and revert your >>> patch. Gdb will automatically detach instead of kill at

Re: [Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2013-01-24 Thread Fabien Chouteau
On 01/24/2013 03:02 AM, Joel Brobecker wrote: >> qAttached is not supported in Qemu yet, this explains why Gdb sends >> "kill" at the end of debug session. I will implement it and revert your >> patch. Gdb will automatically detach instead of kill at the end of >> debugging session. > > I would ma

Re: [Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2013-01-24 Thread Fabien Chouteau
On 01/23/2013 07:44 PM, Jan Kiszka wrote: > > PS: If you are looking for kill in the meantime: "monitor quit" > I didn't know we can use monitor from Gdb, thanks for the info. -- Fabien Chouteau

Re: [Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2013-01-23 Thread Joel Brobecker
> qAttached is not supported in Qemu yet, this explains why Gdb sends > "kill" at the end of debug session. I will implement it and revert your > patch. Gdb will automatically detach instead of kill at the end of > debugging session. I would make it configurable by the command-line, to allow for b

Re: [Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2013-01-23 Thread Jan Kiszka
On 2013-01-23 19:04, Fabien Chouteau wrote: > On 01/22/2013 03:59 PM, Jan Kiszka wrote: >> On 2013-01-22 15:04, Fabien Chouteau wrote: >>> Hello Qemu folks, >>> >>> I'm sorry to be (very) late, but I do not agree with this patch. >>> >>> Your modification just makes the "kill" command behave like "

Re: [Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2013-01-23 Thread Fabien Chouteau
On 01/22/2013 03:59 PM, Jan Kiszka wrote: > On 2013-01-22 15:04, Fabien Chouteau wrote: >> Hello Qemu folks, >> >> I'm sorry to be (very) late, but I do not agree with this patch. >> >> Your modification just makes the "kill" command behave like "detach", so >> why not use "detach" instead? > > gd

Re: [Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2013-01-22 Thread Jan Kiszka
On 2013-01-22 15:04, Fabien Chouteau wrote: > Hello Qemu folks, > > I'm sorry to be (very) late, but I do not agree with this patch. > > Your modification just makes the "kill" command behave like "detach", so > why not use "detach" instead? gdb automatically issues kill when you quite. This is

[Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2013-01-22 Thread Fabien Chouteau
Hello Qemu folks, I'm sorry to be (very) late, but I do not agree with this patch. Your modification just makes the "kill" command behave like "detach", so why not use "detach" instead? "kill" has its own semantic and it's important to keep it. So I suggest we revert this patch. Regards, > Too

Re: [Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2012-03-11 Thread Blue Swirl
Thanks, applied. I've been an accidental killer myself countless times. On Tue, Mar 6, 2012 at 17:32, Jan Kiszka wrote: > Too many VM kittens were killed since 7d03f82f81. Another one just died > under my fat fingers. > > When you quit a kgdb session, does the Linux kernel power off? Or when > yo

[Qemu-devel] [PATCH] gdbstub: Do not kill target in system emulation mode

2012-03-06 Thread Jan Kiszka
Too many VM kittens were killed since 7d03f82f81. Another one just died under my fat fingers. When you quit a kgdb session, does the Linux kernel power off? Or when you terminate gdb attached to a hardware debugger, does your board vanish in space? No. So let's stop terminating QEMU when the gdbs