Re: [Qemu-devel] [PATCH] fw_cfg: print error message when reading splashfile failed

2018-10-31 Thread Li Qiang
Hello all, I have sent out another patch. As the email's subject and commit message changed, I'm not sure is it suitable to add Philippe and Laszlo's R-b tag. Thanks, Li Qiang Markus Armbruster 于2018年10月31日周三 下午11:36写道： > Philippe Mathieu-Daudé writes: > > > On 24/10/18 7:12, Li Qiang wrote:

Re: [Qemu-devel] [PATCH] fw_cfg: print error message when reading splashfile failed

2018-10-31 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 24/10/18 7:12, Li Qiang wrote: >> Also remove unnecessary 'res' variable. >> >> Signed-off-by: Li Qiang >> --- >> hw/nvram/fw_cfg.c | 7 +++ >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c >> i

Re: [Qemu-devel] [PATCH] fw_cfg: print error message when reading splashfile failed

2018-10-24 Thread Philippe Mathieu-Daudé
On 24/10/18 7:12, Li Qiang wrote: Also remove unnecessary 'res' variable. Signed-off-by: Li Qiang --- hw/nvram/fw_cfg.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 946f765..f4a52d8 100644 --- a/hw/nvram/fw_cfg.c +++ b

Re: [Qemu-devel] [PATCH] fw_cfg: print error message when reading splashfile failed

2018-10-24 Thread Laszlo Ersek
On 10/24/18 07:12, Li Qiang wrote: > Also remove unnecessary 'res' variable. > > Signed-off-by: Li Qiang > --- > hw/nvram/fw_cfg.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c > index 946f765..f4a52d8 100644 > --- a/hw/nvr

[Qemu-devel] [PATCH] fw_cfg: print error message when reading splashfile failed

2018-10-23 Thread Li Qiang
Also remove unnecessary 'res' variable. Signed-off-by: Li Qiang --- hw/nvram/fw_cfg.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 946f765..f4a52d8 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -68,15 +68,14 @@