Re: [Qemu-devel] [PATCH] fix monitor

2013-04-03 Thread Peter Lieven
On 03.04.2013 15:36, Luiz Capitulino wrote: On Wed, 03 Apr 2013 14:35:46 +0200 Gerd Hoffmann wrote: On 04/03/13 14:17, Peter Lieven wrote: Hi Gerd, I today saw this assert when live migrating a VM. Is this related? The below patch was already applied. qemu-1.4.5: /usr/src/qemu-1.4.5/monitor

Re: [Qemu-devel] [PATCH] fix monitor

2013-04-03 Thread Luiz Capitulino
On Wed, 03 Apr 2013 14:35:46 +0200 Gerd Hoffmann wrote: > On 04/03/13 14:17, Peter Lieven wrote: > > Hi Gerd, > > > > I today saw this assert when live migrating a VM. Is this related? The > > below patch was already applied. > > > > qemu-1.4.5: /usr/src/qemu-1.4.5/monitor.c:297: monitor_puts:

Re: [Qemu-devel] [PATCH] fix monitor

2013-04-03 Thread Gerd Hoffmann
On 04/03/13 14:17, Peter Lieven wrote: > Hi Gerd, > > I today saw this assert when live migrating a VM. Is this related? The > below patch was already applied. > > qemu-1.4.5: /usr/src/qemu-1.4.5/monitor.c:297: monitor_puts: Assertion > `mon->outbuf_index < sizeof(mon->outbuf) - 1' failed. Proba

Re: [Qemu-devel] [PATCH] fix monitor

2013-04-03 Thread Peter Lieven
Hi Gerd, I today saw this assert when live migrating a VM. Is this related? The below patch was already applied. qemu-1.4.5: /usr/src/qemu-1.4.5/monitor.c:297: monitor_puts: Assertion `mon->outbuf_index < sizeof(mon->outbuf) - 1' failed. Peter Gerd Hoffmann wrote: > chardev flow control broke

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Anthony Liguori
Markus Armbruster writes: > Gerd Hoffmann writes: > >> chardev flow control broke monitor, fix it by adding watch support. >> >> Signed-off-by: Gerd Hoffmann >> --- >> v2: fix tyops >> --- > > Subject lacks v2. Anthony, holler if you want a respin to unconfuse > your tools. I already processe

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Markus Armbruster
Gerd Hoffmann writes: > chardev flow control broke monitor, fix it by adding watch support. > > Signed-off-by: Gerd Hoffmann > --- > v2: fix tyops > --- Subject lacks v2. Anthony, holler if you want a respin to unconfuse your tools.

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Gerd Hoffmann
On 03/19/13 15:45, Laszlo Ersek wrote: > On 03/19/13 15:04, Gerd Hoffmann wrote: >> chardev flow control broke monitor, fix it by adding watch support. >> >> Signed-off-by: Gerd Hoffmann >> --- >> v2: fix tyops > > Well played, Sir :) > >> --- >> monitor.c | 23 +-- >> 1 f

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Laszlo Ersek
On 03/19/13 15:04, Gerd Hoffmann wrote: > chardev flow control broke monitor, fix it by adding watch support. > > Signed-off-by: Gerd Hoffmann > --- > v2: fix tyops Well played, Sir :) > --- > monitor.c | 23 +-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > dif

[Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Gerd Hoffmann
chardev flow control broke monitor, fix it by adding watch support. Signed-off-by: Gerd Hoffmann --- v2: fix tyops --- monitor.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 112e920..74807f9 100644 --- a/monitor.c +++

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Hans de Goede
Hi, Looks good, one minor nitpick. On 03/19/2013 10:57 AM, Gerd Hoffmann wrote: chardev flow control broke monitor, fix it by adding watch support. --- monitor.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 112e920

[Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Gerd Hoffmann
chardev flow control broke monitor, fix it by adding watch support. --- monitor.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 112e920..680d344 100644 --- a/monitor.c +++ b/monitor.c @@ -261,11 +261,30 @@ int monitor_rea

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Erlon Cruz
On Thu, Jan 31, 2013 at 1:12 PM, Luiz Capitulino wrote: > On Thu, 31 Jan 2013 05:12:25 -0800 > "Erlon Cruz" wrote: > > > Legal Disclaimer: > > The information contained in this message may be privileged and > confidential. It is intended to be read only by the individual or entity to > whom it is

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Luiz Capitulino
On Thu, 31 Jan 2013 05:12:25 -0800 "Erlon Cruz" wrote: > Legal Disclaimer: > The information contained in this message may be privileged and confidential. > It is intended to be read only by the individual or entity to whom it is > addressed or by their designee. If the reader of this message i

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Erlon Cruz
On 01/31/2013 09:33 AM, Luiz Capitulino wrote: > On Thu, 31 Jan 2013 10:51:10 +0100 > Markus Armbruster wrote: > >> "Erlon Cruz" writes: >> >>> QEMU monitor command 'info registers' only displays information for the >>> first >>> CPU. This fix that by show registers information for each CPU in t

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Erlon Cruz
On 01/31/2013 07:51 AM, Markus Armbruster wrote: > "Erlon Cruz" writes: > >> QEMU monitor command 'info registers' only displays information for the first >> CPU. This fix that by show registers information for each CPU in the system > This is incorrect. It displays information for the *current*

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 31 Jan 2013 10:51:10 +0100 > Markus Armbruster wrote: > >> "Erlon Cruz" writes: >> >> > QEMU monitor command 'info registers' only displays information >> > for the first >> > CPU. This fix that by show registers information for each CPU in the system >> >> T

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Luiz Capitulino
On Thu, 31 Jan 2013 10:51:10 +0100 Markus Armbruster wrote: > "Erlon Cruz" writes: > > > QEMU monitor command 'info registers' only displays information for the > > first > > CPU. This fix that by show registers information for each CPU in the system > > This is incorrect. It displays inform

Re: [Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-31 Thread Markus Armbruster
"Erlon Cruz" writes: > QEMU monitor command 'info registers' only displays information for the first > CPU. This fix that by show registers information for each CPU in the system This is incorrect. It displays information for the *current* CPU. Monitor command "cpu" selects the current CPU. I

[Qemu-devel] [PATCH] Fix monitor 'info registers' command on multi processor guests

2013-01-30 Thread Erlon Cruz
QEMU monitor command 'info registers' only displays information for the first CPU. This fix that by show registers information for each CPU in the system Signed-off-by: erlon.c...@fit-tecnologia.org.br --- monitor.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) dif