On 10/29/2015 04:07 PM, Michael Tokarev wrote:
It is a general common sense maybe, I dunno. There's lot of code which does not
comply with the coding styles, and at the very least, when you change just that
without actually changing the code, git blame stops working, showing your non-
change
29.10.2015 10:57, Cao jin wrote:
> Thanks Michael. and I am sorry if it bothered you.
There's nothing to worry about, really.
> Maybe it can be avoid to have a clear definition of "trivial" to direct the
> newbies like me:P
It is a general common sense maybe, I dunno. There's lot of code which
Thanks Michael. and I am sorry if it bothered you.
Maybe it can be avoid to have a clear definition of "trivial" to direct
the newbies like me:P
On 10/29/2015 03:45 PM, Michael Tokarev wrote:
25.10.2015 11:23, Cao jin wrote:
bad indentation conflicts with CODING_STYLE doc
I don't like patch
25.10.2015 11:23, Cao jin wrote:
> bad indentation conflicts with CODING_STYLE doc
I don't like patches which just change coding style.
It is often agreed that when you fix some code you
can also fix indentation of surrounding code, but
just fixing coding style isn't very productive.
Yet I'm appl
On Mon, Oct 26, 2015 at 08:07:34PM +0800, Cao jin wrote:
> Sorry, I just find that maybe I should cc this patch to
> qemu-triv...@nongnu.org
Indeed.
> On 10/25/2015 04:23 PM, Cao jin wrote:
> >bad indentation conflicts with CODING_STYLE doc
> >
> >Signed-off-by: Cao jin
> >---
> > hw/pci/pcie.c
Sorry, I just find that maybe I should cc this patch to
qemu-triv...@nongnu.org
On 10/25/2015 04:23 PM, Cao jin wrote:
bad indentation conflicts with CODING_STYLE doc
Signed-off-by: Cao jin
---
hw/pci/pcie.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/h
bad indentation conflicts with CODING_STYLE doc
Signed-off-by: Cao jin
---
hw/pci/pcie.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 6e28985..e4bfe91 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -413,13 +413,13 @@ void
