Re: [Qemu-devel] [PATCH] file-posix: add rough-block-status parameter

2019-01-09 Thread Denis V . Lunev
On 1/9/19 8:09 PM, Kevin Wolf wrote: > Am 09.01.2019 um 17:55 hat Paolo Bonzini geschrieben: >> On 09/01/19 17:51, Kevin Wolf wrote: >>> Am 09.01.2019 um 17:42 hat Paolo Bonzini geschrieben: On 09/01/19 12:23, Kevin Wolf wrote: > Also note that this is only metadata preallocation; full pre

Re: [Qemu-devel] [PATCH] file-posix: add rough-block-status parameter

2019-01-09 Thread Kevin Wolf
Am 09.01.2019 um 17:55 hat Paolo Bonzini geschrieben: > On 09/01/19 17:51, Kevin Wolf wrote: > > Am 09.01.2019 um 17:42 hat Paolo Bonzini geschrieben: > >> On 09/01/19 12:23, Kevin Wolf wrote: > >>> Also note that this is only metadata preallocation; full preallocation > >>> will still return alloc

Re: [Qemu-devel] [PATCH] file-posix: add rough-block-status parameter

2019-01-09 Thread Eric Blake
On 1/9/19 10:51 AM, Kevin Wolf wrote: > Am 09.01.2019 um 17:42 hat Paolo Bonzini geschrieben: >> On 09/01/19 12:23, Kevin Wolf wrote: >>> Also note that this is only metadata preallocation; full preallocation >>> will still return allocated for the protocol layer and so it will always >>> be slow.

Re: [Qemu-devel] [PATCH] file-posix: add rough-block-status parameter

2019-01-09 Thread Kevin Wolf
Am 09.01.2019 um 17:42 hat Paolo Bonzini geschrieben: > On 09/01/19 12:23, Kevin Wolf wrote: > > Also note that this is only metadata preallocation; full preallocation > > will still return allocated for the protocol layer and so it will always > > be slow. > > Full preallocation these days can cr

Re: [Qemu-devel] [PATCH] file-posix: add rough-block-status parameter

2019-01-09 Thread Paolo Bonzini
On 09/01/19 17:51, Kevin Wolf wrote: > Am 09.01.2019 um 17:42 hat Paolo Bonzini geschrieben: >> On 09/01/19 12:23, Kevin Wolf wrote: >>> Also note that this is only metadata preallocation; full preallocation >>> will still return allocated for the protocol layer and so it will always >>> be slow. >

Re: [Qemu-devel] [PATCH] file-posix: add rough-block-status parameter

2019-01-09 Thread Paolo Bonzini
On 09/01/19 12:23, Kevin Wolf wrote: > Also note that this is only metadata preallocation; full preallocation > will still return allocated for the protocol layer and so it will always > be slow. Full preallocation these days can create images with preallocated but known-zero blocks, I think? Pao

Re: [Qemu-devel] [PATCH] file-posix: add rough-block-status parameter

2019-01-09 Thread Kevin Wolf
Am 08.01.2019 um 20:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > bdrv_co_block_status digs bs->file for additional, more accurate search > for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > This accuracy is not free: assume we have qcow2 disk. Actually, qcow2 > knows, wher

Re: [Qemu-devel] [PATCH] file-posix: add rough-block-status parameter

2019-01-08 Thread Eric Blake
On 1/8/19 1:45 PM, Vladimir Sementsov-Ogievskiy wrote: > bdrv_co_block_status digs bs->file for additional, more accurate search > for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > This accuracy is not free: assume we have qcow2 disk. Actually, qcow2 > knows, where are holes an

[Qemu-devel] [PATCH] file-posix: add rough-block-status parameter

2019-01-08 Thread Vladimir Sementsov-Ogievskiy
bdrv_co_block_status digs bs->file for additional, more accurate search for hole inside region, reported as DATA by bs since 5daa74a6ebc. This accuracy is not free: assume we have qcow2 disk. Actually, qcow2 knows, where are holes and where is data. But every block_status request calls lseek addit