Re: [Qemu-devel] [PATCH] file-posix: Support fallocate for block device

2018-03-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1522204637-29589-1-git-send-email-zhenwei...@youruncloud.com Subject: [Qemu-devel] [PATCH] file-posix: Support fallocate for block device === TEST SCRIPT BEGIN === #!/bin

Re: [Qemu-devel] [PATCH] file-posix: Support fallocate for block device

2018-03-28 Thread Eric Blake
On 03/27/2018 09:37 PM, zhenwei.pi wrote: since linux 4.9, block device supports fallocate. kernel issues block device zereout request and invalidates page cache. So ioctl(fd, FALLOC_FL_ZERO_RANGE...) is safer than ioctl(fd, did you mean fallocate() in the first half of the sentence? BLKZEROO

[Qemu-devel] [PATCH] file-posix: Support fallocate for block device

2018-03-27 Thread zhenwei.pi
since linux 4.9, block device supports fallocate. kernel issues block device zereout request and invalidates page cache. So ioctl(fd, FALLOC_FL_ZERO_RANGE...) is safer than ioctl(fd, BLKZEROOUT...). try to call do_fallocate, if failing, fallback. use new field "has_fallocate_zero_range" with defau