Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-05 Thread Paolo Bonzini
On 05/07/2018 07:56, Cédric Le Goater wrote: > Hello Paolo, > > On 07/04/2018 02:16 PM, Paolo Bonzini wrote: >> On 04/07/2018 11:55, Peter Xu wrote: commit b0e56e0b63f350691b52d3e75e89bb64143fbeff Author: Hu Tao Date: Wed Apr 2 15:13:27 2014 +0800 unset

Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-04 Thread Cédric Le Goater
Hello Paolo, On 07/04/2018 02:16 PM, Paolo Bonzini wrote: > On 04/07/2018 11:55, Peter Xu wrote: >>> commit b0e56e0b63f350691b52d3e75e89bb64143fbeff >>> Author: Hu Tao >>> Date: Wed Apr 2 15:13:27 2014 +0800 >>> >>> unset RAMBlock idstr when unregister MemoryRegion >>> >>> S

Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 11:55, Peter Xu wrote: >> commit b0e56e0b63f350691b52d3e75e89bb64143fbeff >> Author: Hu Tao >> Date: Wed Apr 2 15:13:27 2014 +0800 >> >> unset RAMBlock idstr when unregister MemoryRegion >> >> Signed-off-by: Hu Tao >> Signed-off-by: Paolo Bonzini >> >> who

Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-04 Thread Peter Xu
On Wed, Jul 04, 2018 at 11:34:55AM +0200, Paolo Bonzini wrote: > On 04/07/2018 08:42, Cédric Le Goater wrote: > > On 07/04/2018 04:26 AM, Peter Xu wrote: > >> On Tue, Jul 03, 2018 at 02:45:24PM +0200, Cédric Le Goater wrote: > >>> On 07/02/2018 05:57 AM, Peter Xu wrote: > On Sun, Jul 01, 2018

Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 08:42, Cédric Le Goater wrote: > On 07/04/2018 04:26 AM, Peter Xu wrote: >> On Tue, Jul 03, 2018 at 02:45:24PM +0200, Cédric Le Goater wrote: >>> On 07/02/2018 05:57 AM, Peter Xu wrote: On Sun, Jul 01, 2018 at 07:19:53PM +0200, Cédric Le Goater wrote: > When a PCI device is u

Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-03 Thread Cédric Le Goater
On 07/04/2018 04:26 AM, Peter Xu wrote: > On Tue, Jul 03, 2018 at 02:45:24PM +0200, Cédric Le Goater wrote: >> On 07/02/2018 05:57 AM, Peter Xu wrote: >>> On Sun, Jul 01, 2018 at 07:19:53PM +0200, Cédric Le Goater wrote: When a PCI device is unplugged, the PCI memory regions are deleted b

Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-03 Thread Peter Xu
On Tue, Jul 03, 2018 at 02:45:24PM +0200, Cédric Le Goater wrote: > On 07/02/2018 05:57 AM, Peter Xu wrote: > > On Sun, Jul 01, 2018 at 07:19:53PM +0200, Cédric Le Goater wrote: > >> When a PCI device is unplugged, the PCI memory regions are deleted > >> before the optional ROM RAMBlock is flagged

Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-03 Thread Cédric Le Goater
On 07/02/2018 05:57 AM, Peter Xu wrote: > On Sun, Jul 01, 2018 at 07:19:53PM +0200, Cédric Le Goater wrote: >> When a PCI device is unplugged, the PCI memory regions are deleted >> before the optional ROM RAMBlock is flagged non-migratable. But, when >> this is done, the RAMBlock has already been c

Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-01 Thread Peter Xu
On Sun, Jul 01, 2018 at 07:19:53PM +0200, Cédric Le Goater wrote: > When a PCI device is unplugged, the PCI memory regions are deleted > before the optional ROM RAMBlock is flagged non-migratable. But, when > this is done, the RAMBlock has already been cleared from the region, > leading to a segv.

[Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-01 Thread Cédric Le Goater
When a PCI device is unplugged, the PCI memory regions are deleted before the optional ROM RAMBlock is flagged non-migratable. But, when this is done, the RAMBlock has already been cleared from the region, leading to a segv. Fix the issue by testing the RAMBlock before flagging it, as it is done i