Re: [Qemu-devel] [PATCH] es1370: simplify MemoryRegionOps

2018-08-02 Thread Paolo Bonzini
On 01/08/2018 19:27, Philippe Mathieu-Daudé wrote: > I guess this code bypass the access_with_adjusted_size() big-endian > bug... But I have no idea if this devices on BE platforms, so for this > nice cleanup: > Reviewed-by: Philippe Mathieu-Daudé What is the big-endian bug, and why is tests/endi

Re: [Qemu-devel] [PATCH] es1370: simplify MemoryRegionOps

2018-08-01 Thread Philippe Mathieu-Daudé
On 08/01/2018 02:06 PM, Paolo Bonzini wrote: > Use the automatic subregister extraction from the memory API, and avoid > that Coverity complains about missing fallthrough comments. > Signed-off-by: Paolo Bonzini > --- > hw/audio/es1370.c | 235 +- > 1 f

[Qemu-devel] [PATCH] es1370: simplify MemoryRegionOps

2018-08-01 Thread Paolo Bonzini
Use the automatic subregister extraction from the memory API, and avoid that Coverity complains about missing fallthrough comments. Signed-off-by: Paolo Bonzini --- hw/audio/es1370.c | 235 +- 1 file changed, 25 insertions(+), 210 deletions(-) diff --