Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

2019-08-21 Thread Gerd Hoffmann
Hi, > > Yep, as long as the queue is not active this is completely harmless. > > So we need to check a bit later. In execute() looks a bit too late > > though, we don't have a good backup plan then. > > > > Does the patch below solve the problem without bad side effects? > That seems to be wo

Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

2019-08-20 Thread Guenter Roeck
On 8/13/19 4:42 AM, Gerd Hoffmann wrote: On Tue, Aug 06, 2019 at 06:23:38AM -0700, Guenter Roeck wrote: On 8/2/19 7:11 AM, Gerd Hoffmann wrote: On Wed, Jul 31, 2019 at 01:08:50PM +0200, Philippe Mathieu-Daudé wrote: On 7/30/19 7:45 PM, Guenter Roeck wrote: The following assert is seen once in

Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

2019-08-14 Thread Guenter Roeck
On Tue, Aug 13, 2019 at 01:42:03PM +0200, Gerd Hoffmann wrote: > On Tue, Aug 06, 2019 at 06:23:38AM -0700, Guenter Roeck wrote: > > On 8/2/19 7:11 AM, Gerd Hoffmann wrote: > > > On Wed, Jul 31, 2019 at 01:08:50PM +0200, Philippe Mathieu-Daudé wrote: > > > > On 7/30/19 7:45 PM, Guenter Roeck wrote:

Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

2019-08-13 Thread Gerd Hoffmann
On Tue, Aug 06, 2019 at 06:23:38AM -0700, Guenter Roeck wrote: > On 8/2/19 7:11 AM, Gerd Hoffmann wrote: > > On Wed, Jul 31, 2019 at 01:08:50PM +0200, Philippe Mathieu-Daudé wrote: > > > On 7/30/19 7:45 PM, Guenter Roeck wrote: > > > > The following assert is seen once in a while while resetting th

Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

2019-08-06 Thread Guenter Roeck
On 8/2/19 7:11 AM, Gerd Hoffmann wrote: On Wed, Jul 31, 2019 at 01:08:50PM +0200, Philippe Mathieu-Daudé wrote: On 7/30/19 7:45 PM, Guenter Roeck wrote: The following assert is seen once in a while while resetting the Linux kernel. qemu-system-x86_64: hw/usb/core.c:734: usb_ep_get: Ass

Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

2019-08-02 Thread Guenter Roeck
On Fri, Aug 02, 2019 at 09:46:26AM -0700, Guenter Roeck wrote: > On Fri, Aug 02, 2019 at 04:11:49PM +0200, Gerd Hoffmann wrote: > > On Wed, Jul 31, 2019 at 01:08:50PM +0200, Philippe Mathieu-Daudé wrote: > > > On 7/30/19 7:45 PM, Guenter Roeck wrote: > > > > The following assert is seen once in a w

Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

2019-08-02 Thread Guenter Roeck
On Fri, Aug 02, 2019 at 04:11:49PM +0200, Gerd Hoffmann wrote: > On Wed, Jul 31, 2019 at 01:08:50PM +0200, Philippe Mathieu-Daudé wrote: > > On 7/30/19 7:45 PM, Guenter Roeck wrote: > > > The following assert is seen once in a while while resetting the > > > Linux kernel. > > > > > > qemu-system-x

Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

2019-08-02 Thread Gerd Hoffmann
On Wed, Jul 31, 2019 at 01:08:50PM +0200, Philippe Mathieu-Daudé wrote: > On 7/30/19 7:45 PM, Guenter Roeck wrote: > > The following assert is seen once in a while while resetting the > > Linux kernel. > > > > qemu-system-x86_64: hw/usb/core.c:734: usb_ep_get: > > Assertion `dev != NULL' faile

Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

2019-07-31 Thread Guenter Roeck
On Wed, Jul 31, 2019 at 01:08:50PM +0200, Philippe Mathieu-Daudé wrote: > On 7/30/19 7:45 PM, Guenter Roeck wrote: > > The following assert is seen once in a while while resetting the > > Linux kernel. > > > > qemu-system-x86_64: hw/usb/core.c:734: usb_ep_get: > > Assertion `dev != NULL' faile

Re: [Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

2019-07-31 Thread Philippe Mathieu-Daudé
On 7/30/19 7:45 PM, Guenter Roeck wrote: > The following assert is seen once in a while while resetting the > Linux kernel. > > qemu-system-x86_64: hw/usb/core.c:734: usb_ep_get: > Assertion `dev != NULL' failed. > > The call to usb_ep_get() originates from ehci_execute(). > Analysis and de

[Qemu-devel] [PATCH] ehci: Ensure that device is not NULL before calling usb_ep_get

2019-07-30 Thread Guenter Roeck
The following assert is seen once in a while while resetting the Linux kernel. qemu-system-x86_64: hw/usb/core.c:734: usb_ep_get: Assertion `dev != NULL' failed. The call to usb_ep_get() originates from ehci_execute(). Analysis and debugging shows that p->queue->dev can indeed be NULL in