Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Jason Wang
On 2016年08月19日 00:57, Paolo Bonzini wrote: On 18/08/2016 16:15, Cao jin wrote: Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, E1000E_USE_MSIX is not necessary too, remove it now. And interrupt flag field intr_state also can be removed now. CC: Dmitry Fleytman CC: Jason Wang

Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Dmitry Fleytman
> On 18 Aug 2016, at 19:41 PM, Markus Armbruster wrote: > > Dmitry Fleytman writes: > >>> On 18 Aug 2016, at 17:15, Cao jin wrote: >>> >>> Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, >>> E1000E_USE_MSIX >>> is not necessary too, remove it now. And interrupt flag field i

Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Markus Armbruster
Markus Armbruster writes: > Dmitry Fleytman writes: > >>> On 18 Aug 2016, at 17:15, Cao jin wrote: [...] >>> @@ -601,7 +596,6 @@ static const VMStateDescription e1000e_vmstate = { >>> VMSTATE_MSIX(parent_obj, E1000EState), >>> >>> VMSTATE_UINT32(ioaddr, E1000EState), >>> -

Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 16:15, Cao jin wrote: > Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, > E1000E_USE_MSIX > is not necessary too, remove it now. And interrupt flag field intr_state also > can be removed now. > > CC: Dmitry Fleytman > CC: Jason Wang > CC: Markus Armbruster > CC:

Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Markus Armbruster
Dmitry Fleytman writes: >> On 18 Aug 2016, at 17:15, Cao jin wrote: >> >> Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, >> E1000E_USE_MSIX >> is not necessary too, remove it now. And interrupt flag field intr_state also >> can be removed now. >> >> CC: Dmitry Fleytman >> CC

Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Dmitry Fleytman
> On 18 Aug 2016, at 17:15, Cao jin wrote: > > Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, > E1000E_USE_MSIX > is not necessary too, remove it now. And interrupt flag field intr_state also > can be removed now. > > CC: Dmitry Fleytman > CC: Jason Wang > CC: Markus Armbrus

[Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Cao jin
Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, E1000E_USE_MSIX is not necessary too, remove it now. And interrupt flag field intr_state also can be removed now. CC: Dmitry Fleytman CC: Jason Wang CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin CC: Paolo Bonz