Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

2017-09-13 Thread Peter Xu
On Wed, Sep 13, 2017 at 09:58:04AM +0200, Cornelia Huck wrote: > On Tue, 12 Sep 2017 12:17:51 +0200 > Marc-André Lureau wrote: > > > Hi Peter > > > > On Tue, Sep 12, 2017 at 5:33 AM, Peter Xu wrote: > > > On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: > > >> It does not really

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

2017-09-13 Thread Cornelia Huck
On Tue, 12 Sep 2017 12:17:51 +0200 Marc-André Lureau wrote: > Hi Peter > > On Tue, Sep 12, 2017 at 5:33 AM, Peter Xu wrote: > > On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: > >> It does not really make sense to dump memory that is not there. > >> > >> Moreover, that fixes a

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

2017-09-12 Thread Peter Xu
On Tue, Sep 12, 2017 at 12:17:51PM +0200, Marc-André Lureau wrote: > Hi Peter > > On Tue, Sep 12, 2017 at 5:33 AM, Peter Xu wrote: > > On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: > >> It does not really make sense to dump memory that is not there. > >> > >> Moreover, that fixes

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

2017-09-12 Thread Marc-André Lureau
Hi Peter On Tue, Sep 12, 2017 at 5:33 AM, Peter Xu wrote: > On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: >> It does not really make sense to dump memory that is not there. >> >> Moreover, that fixes a segmentation fault when calling dump-guest-memory >> with no filter for a mach

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

2017-09-11 Thread Peter Xu
On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: > It does not really make sense to dump memory that is not there. > > Moreover, that fixes a segmentation fault when calling dump-guest-memory > with no filter for a machine with no memory defined. > > New behaviour is: > > (qemu) du

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

2017-09-11 Thread Peter Xu
On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: > It does not really make sense to dump memory that is not there. > > Moreover, that fixes a segmentation fault when calling dump-guest-memory > with no filter for a machine with no memory defined. > > New behaviour is: > > (qemu) du

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

2017-09-11 Thread Greg Kurz
On Mon, 11 Sep 2017 15:26:27 +0200 Cornelia Huck wrote: > It does not really make sense to dump memory that is not there. > > Moreover, that fixes a segmentation fault when calling dump-guest-memory > with no filter for a machine with no memory defined. > > New behaviour is: > > (qemu) dump-gu

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

2017-09-11 Thread Laurent Vivier
On 11/09/2017 15:26, Cornelia Huck wrote: > It does not really make sense to dump memory that is not there. > > Moreover, that fixes a segmentation fault when calling dump-guest-memory > with no filter for a machine with no memory defined. > > New behaviour is: > > (qemu) dump-guest-memory /dev/

[Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

2017-09-11 Thread Cornelia Huck
It does not really make sense to dump memory that is not there. Moreover, that fixes a segmentation fault when calling dump-guest-memory with no filter for a machine with no memory defined. New behaviour is: (qemu) dump-guest-memory /dev/null dump: no guest memory to dump (qemu) dump-guest-memor