Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-11 Thread Eduardo Habkost
On Wed, Jul 11, 2018 at 06:19:33PM +0200, Paolo Bonzini wrote: > On 11/07/2018 18:00, Eduardo Habkost wrote: > >> @@ -237,7 +237,7 @@ int x86_cpu_write_elf32_note(WriteCoreDumpFunction f, > >> CPUState *cs, > >> * please count up QEMUCPUSTATE_VERSION if you have changed definition of > >> * QE

Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 18:26, Viktor Prutyanov wrote: >> Where are the tools using this information, that need to be >> updated? Won't this break existing versions of those tools? >> >> Is the dump format and pointers to available tools documented >> somewhere? > I hope that someone from community knows ab

Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-11 Thread Viktor Prutyanov
On Wed, 11 Jul 2018 13:00:25 -0300 Eduardo Habkost wrote: > On Tue, Jul 10, 2018 at 06:21:09PM +0300, Viktor Prutyanov wrote: > > This patch adds field with content of KERNEL_GS_BASE MSR to QEMU > > note in ELF dump. > > > > On Windows, if all vCPUs are running usermode tasks at the time the > >

Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 18:00, Eduardo Habkost wrote: >> @@ -237,7 +237,7 @@ int x86_cpu_write_elf32_note(WriteCoreDumpFunction f, >> CPUState *cs, >> * please count up QEMUCPUSTATE_VERSION if you have changed definition of >> * QEMUCPUState, and modify the tools using this information accordingly. > Wh

Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-11 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 06:21:09PM +0300, Viktor Prutyanov wrote: > This patch adds field with content of KERNEL_GS_BASE MSR to QEMU note in > ELF dump. > > On Windows, if all vCPUs are running usermode tasks at the time the dump is > created, this can be helpful in the discovery of guest system s

[Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state

2018-07-10 Thread Viktor Prutyanov
This patch adds field with content of KERNEL_GS_BASE MSR to QEMU note in ELF dump. On Windows, if all vCPUs are running usermode tasks at the time the dump is created, this can be helpful in the discovery of guest system structures during conversion ELF dump to MEMORY.DMP dump. Signed-off-by: Vik