Re: [Qemu-devel] [PATCH] don't die if switching to fullscreen mode fails

2008-02-26 Thread Andreas Winkelbauer
hi, >> use windowed mode as fallback option if we are already in fullscreen >> mode and the new resolution is too high and print a message to the >> console > > Do you end up with a window bigger than the screen, then? Is there a > chance the user can escape from this situation, i.e. reach all pa

Re: [Qemu-devel] [PATCH] don't die if switching to fullscreen mode fails

2008-02-26 Thread Andreas Winkelbauer
hi, > Wow. This patch is messy, if I may say so. There must be a more > elegant way to do this, especially given the fact that you remove > atexit(sdl_cleanup)s without explanation. well, the diff output is messy, because I added sdl_resize2() above sdl_resize() to avoid adding a forward decl

Re: [Qemu-devel] [PATCH] don't die if switching to fullscreen mode fails

2008-02-26 Thread Markus Hitter
Am 26.02.2008 um 13:48 schrieb Andreas Winkelbauer: This patch changes the behaviour as follows: * deny switching to fullscreen mode if the resolution is too high and print a message to the console Very good idea. * use windowed mode as fallback option if we are already in fullscreen

Re: [Qemu-devel] [PATCH] don't die if switching to fullscreen mode fails

2008-02-26 Thread Johannes Schindelin
Hi, On Tue, 26 Feb 2008, Andreas Winkelbauer wrote: > the attached patch fixes some glitches when switching to fullscreen mode > using ctrl+alt+f or when booting using -full-screen. Wow. This patch is messy, if I may say so. There must be a more elegant way to do this, especially given the f

[Qemu-devel] [PATCH] don't die if switching to fullscreen mode fails

2008-02-26 Thread Andreas Winkelbauer
hi, the attached patch fixes some glitches when switching to fullscreen mode using ctrl+alt+f or when booting using -full-screen. up to now the VM simply dies if one of the following situations occur: * user switches from windowed to fullscreen mode using a resolution which is too high (mea