On 10 July 2013 06:08, Michael Tokarev wrote:
> I updated the git branch on my site --
>
> http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/mjt-dt-nographic
>
> (two patches on the top). This now includes the `make check' fix by
> flipping the check (FW_CFG_NOGRAPHIC==1 vs ==0), more doc
10.07.2013 02:03, Anthony Liguori wrote:
> Peter Maydell writes:
>
>> On 9 July 2013 22:24, Anthony Liguori wrote:
>>> Peter Maydell writes:
Why the heck are we telling the guest that the user
specified -nographic anyhow? It's a dumb guest ABI...
>>>
>>> I believe OpenBIOS uses this t
10.07.2013 08:45, Michael Tokarev wrote:
[]
> Besides, -- I just noticed -- we're discussing a V1 of this patch,
> while I already sent a v3, -- it has a much more appropriate logic
> for the Ctrl+C handling. The only issue I see with it is the make
> check breakage which is easy to fix by s/==0/=
10.07.2013 01:24, Anthony Liguori wrote:
> Peter Maydell writes:
>
>> On 9 July 2013 21:45, Anthony Liguori wrote:
>>> Michael Tokarev writes:
09.07.2013 22:37, Anthony Liguori wrote:
> ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic:
> assertion failed
10.07.2013 00:45, Anthony Liguori wrote:
> Michael Tokarev writes:
>
>> 09.07.2013 22:37, Anthony Liguori wrote:
>>> Michael Tokarev writes:
>>>
It looks like initially there was -nographic option to turn
off display, now there's another option of the same sort,
-display none. Bu
Peter Maydell writes:
> On 9 July 2013 22:24, Anthony Liguori wrote:
>> Peter Maydell writes:
>>> Why the heck are we telling the guest that the user
>>> specified -nographic anyhow? It's a dumb guest ABI...
>>
>> I believe OpenBIOS uses this to determine if it should display messages
>> on ser
On 9 July 2013 22:24, Anthony Liguori wrote:
> Peter Maydell writes:
>> Why the heck are we telling the guest that the user
>> specified -nographic anyhow? It's a dumb guest ABI...
>
> I believe OpenBIOS uses this to determine if it should display messages
> on serial or on the graphic display.
>
Peter Maydell writes:
> On 9 July 2013 21:45, Anthony Liguori wrote:
>> Michael Tokarev writes:
>>> 09.07.2013 22:37, Anthony Liguori wrote:
ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic:
assertion failed (qfw_cfg_get_u16(fw_cfg, FW_CFG_NOGRAPHIC) == 0):
On 9 July 2013 21:45, Anthony Liguori wrote:
> Michael Tokarev writes:
>> 09.07.2013 22:37, Anthony Liguori wrote:
>>> ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic:
>>> assertion failed (qfw_cfg_get_u16(fw_cfg, FW_CFG_NOGRAPHIC) == 0): (1 == 0)
>>> GTester: last ran
Michael Tokarev writes:
> 09.07.2013 22:37, Anthony Liguori wrote:
>> Michael Tokarev writes:
>>
>>> It looks like initially there was -nographic option to turn
>>> off display, now there's another option of the same sort,
>>> -display none. But code in other places of qemu checks for
>>> DT_N
09.07.2013 22:37, Anthony Liguori wrote:
> Michael Tokarev writes:
>
>> It looks like initially there was -nographic option to turn
>> off display, now there's another option of the same sort,
>> -display none. But code in other places of qemu checks for
>> DT_NOGRAPHIC and does not work well wi
Michael Tokarev writes:
> It looks like initially there was -nographic option to turn
> off display, now there's another option of the same sort,
> -display none. But code in other places of qemu checks for
> DT_NOGRAPHIC and does not work well with -display none.
> Make DT_NOGRAPHIC an internal
Il 28/06/2013 14:05, Andreas Färber ha scritto:
> BTW just try it out using the following to see for yourself:
>
> $ qemu-system-ppc -nographic
>
> should get you to an interactive OpenBIOS prompt. Same for sparc.
> This involves communicating to firmware that we are in -nographic mode,
> which t
On 28 June 2013 13:05, Michael Tokarev wrote:
> 28.06.2013 15:55, Peter Maydell wrote:
>> The point is that one of the things -nographic does, as well
>> as disabling the graphics display, is to redirect the serial
>> port (among other things) to stdio. That's why there's code
>> in the char backe
Il 28/06/2013 14:05, Michael Tokarev ha scritto:
> That's exactly why I don't think looking at -nographic here in
> serial code is wrong. It should do the same regardless of
> -nographic - if, say, serial is redirected to stdio, it should
> always pass Ctrl+C to guest instead of killing it. So I'
28.06.2013 15:55, Peter Maydell wrote:
> On 28 June 2013 12:50, Michael Tokarev wrote:
>> This ctrl+c handling is only about when you explicitly redirected
>> some other char device to guest, such as serial port. Which don't
>> have much to do with display I think, hence I don't understand the
>
Il 28/06/2013 13:43, Michael Tokarev ha scritto:
>> >
>> > All I'm saying is that I use -display none and I like that
>> > it defaults to "ctrl-c works and kills qemu" and I don't
>> > want you to break that :-)
> I'm not. Code in qemu-char.c:
>
> static bool stdio_allow_signal;
>
> static void
Am 28.06.2013 13:50, schrieb Michael Tokarev:
> 28.06.2013 15:45, Andreas Färber пишет:
>> Am 28.06.2013 13:29, schrieb Michael Tokarev:
>>> 28.06.2013 15:24, Peter Maydell wrote:
> []
...in particular I don't think "-display none" should
mean "don't allow ctrl-c" (though -nographic shoul
On 28 June 2013 12:50, Michael Tokarev wrote:
> Um. With either -nographic or -display none, there's no "display"
> per se, and it is the "display" who relays keypresses and such into
> guest. Without display, the guest becomes headless completely, not
> only it does not have a monitor of a video
Am 28.06.2013 13:50, schrieb Michael Tokarev:
> 28.06.2013 15:45, Andreas Färber пишет:
>> Am 28.06.2013 13:29, schrieb Michael Tokarev:
>>> 28.06.2013 15:24, Peter Maydell wrote:
> []
...in particular I don't think "-display none" should
mean "don't allow ctrl-c" (though -nographic shoul
On 28 June 2013 12:43, Michael Tokarev wrote:
> Note it is used only for stdio char device, like -serial stdio,
> so if you _just_ use -display none, without -serial stdio, you
> wont notice a change.
Yes, I use "-display none -serial stdio".
-- PMM
28.06.2013 15:45, Andreas Färber пишет:
> Am 28.06.2013 13:29, schrieb Michael Tokarev:
>> 28.06.2013 15:24, Peter Maydell wrote:
[]
>>> ...in particular I don't think "-display none" should
>>> mean "don't allow ctrl-c" (though -nographic should
>>> continue to have that effect), and this patch cu
Am 28.06.2013 13:29, schrieb Michael Tokarev:
> 28.06.2013 15:24, Peter Maydell wrote:
>> On 19 June 2013 13:34, Michael Tokarev wrote:
>>> It looks like initially there was -nographic option to turn
>>> off display, now there's another option of the same sort,
>>> -display none. But code in othe
28.06.2013 15:34, Peter Maydell wrote:
> On 28 June 2013 12:29, Michael Tokarev wrote:
>> 28.06.2013 15:24, Peter Maydell wrote:
>>> ...in particular I don't think "-display none" should
>>> mean "don't allow ctrl-c" (though -nographic should
>>> continue to have that effect), and this patch curre
On 28 June 2013 12:29, Michael Tokarev wrote:
> 28.06.2013 15:24, Peter Maydell wrote:
>> ...in particular I don't think "-display none" should
>> mean "don't allow ctrl-c" (though -nographic should
>> continue to have that effect), and this patch currently
>> introduces that behaviour change.
>
>
28.06.2013 15:24, Peter Maydell wrote:
> On 19 June 2013 13:34, Michael Tokarev wrote:
>> It looks like initially there was -nographic option to turn
>> off display, now there's another option of the same sort,
>> -display none. But code in other places of qemu checks for
>> DT_NOGRAPHIC and does
On 19 June 2013 13:34, Michael Tokarev wrote:
> It looks like initially there was -nographic option to turn
> off display, now there's another option of the same sort,
> -display none. But code in other places of qemu checks for
> DT_NOGRAPHIC and does not work well with -display none.
> Make DT_
Ping?
19.06.2013 16:34, Michael Tokarev wrote:
> It looks like initially there was -nographic option to turn
> off display, now there's another option of the same sort,
> -display none. But code in other places of qemu checks for
> DT_NOGRAPHIC and does not work well with -display none.
> Make DT
It looks like initially there was -nographic option to turn
off display, now there's another option of the same sort,
-display none. But code in other places of qemu checks for
DT_NOGRAPHIC and does not work well with -display none.
Make DT_NOGRAPHIC an internal version which selects DT_NONE,
and
29 matches
Mail list logo
