Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2014-01-08 Thread Loic Dachary
On 08/01/2014 05:33, Stefan Hajnoczi wrote: > On Mon, Jan 06, 2014 at 04:50:41PM +0100, Loic Dachary wrote: >> >> >> On 06/01/2014 03:23, Stefan Hajnoczi wrote: >>> On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote: diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/co

Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2014-01-07 Thread Stefan Hajnoczi
On Mon, Jan 06, 2014 at 04:50:41PM +0100, Loic Dachary wrote: > > > On 06/01/2014 03:23, Stefan Hajnoczi wrote: > > On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote: > >> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc > >> index 28ba0d9..af66bbd 100644 > >> -

Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2014-01-06 Thread Loic Dachary
On 06/01/2014 03:23, Stefan Hajnoczi wrote: > On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote: >> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc >> index 28ba0d9..af66bbd 100644 >> --- a/tests/qemu-iotests/common.rc >> +++ b/tests/qemu-iotests/common.rc >> @

Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2014-01-05 Thread Stefan Hajnoczi
On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote: > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc > index 28ba0d9..af66bbd 100644 > --- a/tests/qemu-iotests/common.rc > +++ b/tests/qemu-iotests/common.rc > @@ -189,7 +189,11 @@ _cleanup_test_img() >

Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2013-12-29 Thread Loic Dachary
Hi Benoît, If I understand correctly common.filter is designed to transform the output and remove variance. In the case of rbd displaying the progress of removal, it is something we probably want to get rid of entirely. Please let me know if I'm missing something and I'll update the patch accor

Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2013-12-29 Thread Benoît Canet
Le Monday 30 Dec 2013 à 01:33:34 (+0100), Loic Dachary a écrit : > Stash the rbd stderr and stdout because it also contains human readable > progress messages : Removing image: 3% complete... in addition to > potential error messages. > > Display the stashed output if rbd exits on error. > > Sign

[Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2013-12-29 Thread Loic Dachary
Stash the rbd stderr and stdout because it also contains human readable progress messages : Removing image: 3% complete... in addition to potential error messages. Display the stashed output if rbd exits on error. Signed-off-by: Loic Dachary --- tests/qemu-iotests/common.rc | 6 +- 1 file c