Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-21 Thread Stefan Hajnoczi
On Mon, Jan 21, 2013 at 12:05:16PM +0200, Michael S. Tsirkin wrote: > On Mon, Jan 21, 2013 at 10:36:18AM +0100, Stefan Hajnoczi wrote: > > On Sat, Jan 19, 2013 at 09:59:57AM +0200, Vadim Rozenfeld wrote: > > > On Friday, January 18, 2013 05:59:37 PM Stefan Hajnoczi wrote: > > > > On Thu, Jan 17, 20

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-21 Thread Michael S. Tsirkin
On Mon, Jan 21, 2013 at 10:36:18AM +0100, Stefan Hajnoczi wrote: > On Sat, Jan 19, 2013 at 09:59:57AM +0200, Vadim Rozenfeld wrote: > > On Friday, January 18, 2013 05:59:37 PM Stefan Hajnoczi wrote: > > > On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: > > > > The viostor virtio-bl

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-21 Thread Stefan Hajnoczi
On Sat, Jan 19, 2013 at 09:59:57AM +0200, Vadim Rozenfeld wrote: > On Friday, January 18, 2013 05:59:37 PM Stefan Hajnoczi wrote: > > On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: > > > The viostor virtio-blk driver for Windows does not use the > > > VIRTIO_CONFIG_S_DRIVER bit.

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-19 Thread Vadim Rozenfeld
On Friday, January 18, 2013 05:59:37 PM Stefan Hajnoczi wrote: > On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: > > The viostor virtio-blk driver for Windows does not use the > > VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK > > bit. Will be added in the

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: > The viostor virtio-blk driver for Windows does not use the > VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK > bit. > > The viostor driver refreshes the virtio-pci status byte sometimes while > the guest is

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-17 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 05:59:17PM +0200, Michael S. Tsirkin wrote: > On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: > > The viostor virtio-blk driver for Windows does not use the > > VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK > > bit. > > > > The vio

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-17 Thread Michael S. Tsirkin
On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: > The viostor virtio-blk driver for Windows does not use the > VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK > bit. > > The viostor driver refreshes the virtio-pci status byte sometimes while > the guest is

[Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-17 Thread Stefan Hajnoczi
The viostor virtio-blk driver for Windows does not use the VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK bit. The viostor driver refreshes the virtio-pci status byte sometimes while the guest is running. We misinterpret 0x4 (VIRTIO_CONFIG_S_DRIVER_OK) as an indication th