Re: [Qemu-devel] [PATCH] crypto: avoid two coverity false positive error reports

2015-11-29 Thread Michael Tokarev
13.11.2015 20:45, Daniel P. Berrange wrote: > In qcrypto_tls_creds_get_path() coverity complains that > we are checking '*creds' for NULL, despite having > dereferenced it previously. This is harmless bug due > to fact that the trace call was too early. Moving it > after the cleanup gets the desire

Re: [Qemu-devel] [PATCH] crypto: avoid two coverity false positive error reports

2015-11-13 Thread Eric Blake
On 11/13/2015 10:45 AM, Daniel P. Berrange wrote: > In qcrypto_tls_creds_get_path() coverity complains that > we are checking '*creds' for NULL, despite having > dereferenced it previously. This is harmless bug due > to fact that the trace call was too early. Moving it > after the cleanup gets the

[Qemu-devel] [PATCH] crypto: avoid two coverity false positive error reports

2015-11-13 Thread Daniel P. Berrange
In qcrypto_tls_creds_get_path() coverity complains that we are checking '*creds' for NULL, despite having dereferenced it previously. This is harmless bug due to fact that the trace call was too early. Moving it after the cleanup gets the desired semantics. In qcrypto_tls_creds_check_cert_key_purp