[Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-09-02 Thread David Gibson
cpu_physical_memory_write_rom(), despite the name, can also be used to write images into RAM - and will often be used that way if the machine uses load_image_targphys() into RAM addresses. However, cpu_physical_memory_write_rom(), unlike cpu_physical_memory_rw() doesn't invalidate any cached TBs w

Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-22 Thread Avi Kivity
On 08/22/2012 02:47 PM, Alexander Graf wrote: >> >> Ok, so IIUC, that means we do need the cpu_physical_memory_write_rom() >> version for load_image_targphys(), and so my original patch is >> basically the right fix. > > Sure it is, I don't think anyone argued about that :). But it's duplicating

Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-22 Thread Alexander Graf
On 22.08.2012, at 13:38, David Gibson wrote: > On Wed, Aug 22, 2012 at 09:05:52AM +0200, Jan Kiszka wrote: >> On 2012-08-22 08:47, Jan Kiszka wrote: >>> On 2012-08-22 07:57, David Gibson wrote: On Wed, Aug 22, 2012 at 07:55:31AM +0200, Alexander Graf wrote: > > On 22.08.2012, at 06:

Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-22 Thread David Gibson
On Wed, Aug 22, 2012 at 09:05:52AM +0200, Jan Kiszka wrote: > On 2012-08-22 08:47, Jan Kiszka wrote: > > On 2012-08-22 07:57, David Gibson wrote: > >> On Wed, Aug 22, 2012 at 07:55:31AM +0200, Alexander Graf wrote: > >>> > >>> On 22.08.2012, at 06:59, David Gibson wrote: > >>> > cpu_physical_m

Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-22 Thread Jan Kiszka
On 2012-08-22 08:47, Jan Kiszka wrote: > On 2012-08-22 07:57, David Gibson wrote: >> On Wed, Aug 22, 2012 at 07:55:31AM +0200, Alexander Graf wrote: >>> >>> On 22.08.2012, at 06:59, David Gibson wrote: >>> cpu_physical_memory_write_rom(), despite the name, can also be used to write images

Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-21 Thread Jan Kiszka
On 2012-08-22 07:57, David Gibson wrote: > On Wed, Aug 22, 2012 at 07:55:31AM +0200, Alexander Graf wrote: >> >> On 22.08.2012, at 06:59, David Gibson wrote: >> >>> cpu_physical_memory_write_rom(), despite the name, can also be used to >>> write images into RAM - and will often be used that way if

Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-21 Thread Alexander Graf
On 22.08.2012, at 08:10, David Gibson wrote: > On Wed, Aug 22, 2012 at 08:02:11AM +0200, Alexander Graf wrote: >> >> On 22.08.2012, at 07:57, David Gibson wrote: >> >>> On Wed, Aug 22, 2012 at 07:55:31AM +0200, Alexander Graf wrote: On 22.08.2012, at 06:59, David Gibson wrote:

Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-21 Thread Alexander Graf
On 22.08.2012, at 08:10, David Gibson wrote: > On Wed, Aug 22, 2012 at 08:02:11AM +0200, Alexander Graf wrote: >> >> On 22.08.2012, at 07:57, David Gibson wrote: >> >>> On Wed, Aug 22, 2012 at 07:55:31AM +0200, Alexander Graf wrote: On 22.08.2012, at 06:59, David Gibson wrote:

Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-21 Thread David Gibson
On Wed, Aug 22, 2012 at 08:02:11AM +0200, Alexander Graf wrote: > > On 22.08.2012, at 07:57, David Gibson wrote: > > > On Wed, Aug 22, 2012 at 07:55:31AM +0200, Alexander Graf wrote: > >> > >> On 22.08.2012, at 06:59, David Gibson wrote: > >> > >>> cpu_physical_memory_write_rom(), despite the n

Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-21 Thread Alexander Graf
On 22.08.2012, at 07:57, David Gibson wrote: > On Wed, Aug 22, 2012 at 07:55:31AM +0200, Alexander Graf wrote: >> >> On 22.08.2012, at 06:59, David Gibson wrote: >> >>> cpu_physical_memory_write_rom(), despite the name, can also be used to >>> write images into RAM - and will often be used that

Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-21 Thread David Gibson
On Wed, Aug 22, 2012 at 07:55:31AM +0200, Alexander Graf wrote: > > On 22.08.2012, at 06:59, David Gibson wrote: > > > cpu_physical_memory_write_rom(), despite the name, can also be used to > > write images into RAM - and will often be used that way if the machine > > uses load_image_targphys() i

Re: [Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-21 Thread Alexander Graf
On 22.08.2012, at 06:59, David Gibson wrote: > cpu_physical_memory_write_rom(), despite the name, can also be used to > write images into RAM - and will often be used that way if the machine > uses load_image_targphys() into RAM addresses. > > However, cpu_physical_memory_write_rom(), unlike cpu

[Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-08-21 Thread David Gibson
cpu_physical_memory_write_rom(), despite the name, can also be used to write images into RAM - and will often be used that way if the machine uses load_image_targphys() into RAM addresses. However, cpu_physical_memory_write_rom(), unlike cpu_physical_memory_rw() does invalidate any cached TBs whic