Re: [Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-13 Thread Amos Kong
On Wed, Jun 12, 2013 at 09:23:37AM -0400, Luiz Capitulino wrote: > On Wed, 12 Jun 2013 15:21:20 +0200 > Gerd Hoffmann wrote: > > > Hi, > > > > >> -{ 'command': 'screendump', 'data': {'filename': 'str'} } > > >> +{ 'command': 'screendump', 'data': {'filename': 'str', > > >> +

Re: [Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-12 Thread Luiz Capitulino
On Wed, 12 Jun 2013 15:21:20 +0200 Gerd Hoffmann wrote: > Hi, > > >> -{ 'command': 'screendump', 'data': {'filename': 'str'} } > >> +{ 'command': 'screendump', 'data': {'filename': 'str', > >> +'*device' : 'str'} } > > > > We can't add new optional paramete

Re: [Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-12 Thread Gerd Hoffmann
Hi, >> -{ 'command': 'screendump', 'data': {'filename': 'str'} } >> +{ 'command': 'screendump', 'data': {'filename': 'str', >> +'*device' : 'str'} } > > We can't add new optional parameters to QMP commands because it's > currently impossible for mngt apps to

Re: [Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-12 Thread Luiz Capitulino
On Wed, 12 Jun 2013 13:51:17 +0200 Gerd Hoffmann wrote: > Add an optional device parameter to the screendump command. > > https://bugzilla.redhat.com/show_bug.cgi?id=903910 > > Signed-off-by: Gerd Hoffmann > --- > hmp-commands.hx |6 +++--- > hmp.c|3 ++- > qapi-schema.js

[Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-12 Thread Gerd Hoffmann
Add an optional device parameter to the screendump command. https://bugzilla.redhat.com/show_bug.cgi?id=903910 Signed-off-by: Gerd Hoffmann --- hmp-commands.hx |6 +++--- hmp.c|3 ++- qapi-schema.json |4 +++- qmp-commands.hx |3 ++- ui/console.c | 17 +++