Re: [Qemu-devel] [PATCH] console: Fix rendering of VGA underline

2011-11-08 Thread Anthony Liguori
On 11/04/2011 04:38 AM, Markus Armbruster wrote: vga_putcharxy()'s underline code sets font_data to 0x instead of 0xff. vga_putcharxy() then reads dmask16[0x>> 4] and dmask4[0x>> 6]. In practice, these out-of-bounds subscripts "only" put a few crap bits into the display surface.

[Qemu-devel] [PATCH] console: Fix rendering of VGA underline

2011-11-04 Thread Markus Armbruster
vga_putcharxy()'s underline code sets font_data to 0x instead of 0xff. vga_putcharxy() then reads dmask16[0x >> 4] and dmask4[0x >> 6]. In practice, these out-of-bounds subscripts "only" put a few crap bits into the display surface. For 32 bit pixels, there's no array access. font_d