Re: [Qemu-devel] [PATCH] console: Avoid segfault in screendump

2018-05-18 Thread Gerd Hoffmann
> > graphic_hw_update(con); > surface = qemu_console_surface(con); > +if (!surface) { > +error_setg(errp, "no surface"); > +return; > +} > + Added to ui queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] console: Avoid segfault in screendump

2018-05-17 Thread Thomas Huth
On 17.05.2018 17:00, Michal Privoznik wrote: > After f771c5440e04626f1 it is possible to select device and > head which to take screendump from. And even though we check if > provided head number falls within range, it may still happen that > the console has no surface yet leading to SIGSEGV: > >

[Qemu-devel] [PATCH] console: Avoid segfault in screendump

2018-05-17 Thread Michal Privoznik
After f771c5440e04626f1 it is possible to select device and head which to take screendump from. And even though we check if provided head number falls within range, it may still happen that the console has no surface yet leading to SIGSEGV: qemu.git $ ./x86_64-softmmu/qemu-system-x86_64 \ -q