Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-26 Thread Eric Blake
On 07/25/2017 10:28 PM, Philippe Mathieu-Daudé wrote: >>> - rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga TAGS >>> cscope.* *.pod *~ */*~ >>> + rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga${EXESUF} >>> TAGS cscope.* *.pod *~ */*~ >>> >>> It's a bit ugly since `rm -f qemu-ga.ex

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Philippe Mathieu-Daudé
As noticed by Michael Roth the ./configure entry for qemu-ga is missing the $(EXESUF) on purpose (see fafcaf1d). Patch dropped for 2.10 On 07/24/2017 10:15 PM, Philippe Mathieu-Daudé wrote: Reported-by: Sameeh Jubran Signed-off-by: Philippe Mathieu-Daudé --- original report from Sameeh Jubra

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Philippe Mathieu-Daudé
On 07/25/2017 11:56 PM, Michael Roth wrote: Quoting Michael Roth (2017-07-25 21:53:41) Quoting Philippe Mathieu-Daudé (2017-07-25 20:45:31) [...] That change was done explicitly via fafcaf1d so that `make qemu-ga` and `make` without --disable-tools specified to configure will generate the MSI

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Michael Roth
Quoting Michael Roth (2017-07-25 21:56:14) > Quoting Michael Roth (2017-07-25 21:53:41) > > Quoting Philippe Mathieu-Daudé (2017-07-25 20:45:31) > > > Hi Michael, > > > > > > On 07/25/2017 08:03 PM, Michael Roth wrote: > > > > Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30) > > > >> Reported-

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Michael Roth
Quoting Michael Roth (2017-07-25 21:53:41) > Quoting Philippe Mathieu-Daudé (2017-07-25 20:45:31) > > Hi Michael, > > > > On 07/25/2017 08:03 PM, Michael Roth wrote: > > > Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30) > > >> Reported-by: Sameeh Jubran > > >> Signed-off-by: Philippe Mathieu

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Michael Roth
Quoting Philippe Mathieu-Daudé (2017-07-25 20:45:31) > Hi Michael, > > On 07/25/2017 08:03 PM, Michael Roth wrote: > > Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30) > >> Reported-by: Sameeh Jubran > >> Signed-off-by: Philippe Mathieu-Daudé > >> --- > >> original report from Sameeh Jubran:

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Philippe Mathieu-Daudé
Hi Michael, On 07/25/2017 08:03 PM, Michael Roth wrote: Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30) Reported-by: Sameeh Jubran Signed-off-by: Philippe Mathieu-Daudé --- original report from Sameeh Jubran: http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg00906.html AFAICT

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Michael Roth
Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30) > Reported-by: Sameeh Jubran > Signed-off-by: Philippe Mathieu-Daudé > --- > original report from Sameeh Jubran: > http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg00906.html AFAICT the issue discussed in the context of that patch is

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 10:15:30PM -0300, Philippe Mathieu-Daudé wrote: > Reported-by: Sameeh Jubran > Signed-off-by: Philippe Mathieu-Daudé > --- > original report from Sameeh Jubran: > http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg00906.html > > Makefile | 2 +- > configure | 2

[Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-24 Thread Philippe Mathieu-Daudé
Reported-by: Sameeh Jubran Signed-off-by: Philippe Mathieu-Daudé --- original report from Sameeh Jubran: http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg00906.html Makefile | 2 +- configure | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile i