Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules option

2015-11-06 Thread Peter Maydell
On 2 November 2015 at 14:06, Stefan Hajnoczi wrote: > According to ./configure all options should have both --enable-foo and > --disable-foo: > > # Always add --enable-foo and --disable-foo command line args. > # Distributions want to ensure that several features are compiled in, and it > #

Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules option

2015-11-03 Thread Fam Zheng
On Tue, 11/03 11:56, Peter Maydell wrote: > On 3 November 2015 at 11:22, Stefan Hajnoczi wrote: > > On Tue, Nov 03, 2015 at 08:24:47AM +0800, Fam Zheng wrote: > >> On Mon, 11/02 14:06, Stefan Hajnoczi wrote: > >> Actually the document is wrong about module support, the default is off: > > > > Thes

Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules option

2015-11-03 Thread Peter Maydell
On 3 November 2015 at 11:22, Stefan Hajnoczi wrote: > On Tue, Nov 03, 2015 at 08:24:47AM +0800, Fam Zheng wrote: >> On Mon, 11/02 14:06, Stefan Hajnoczi wrote: >> Actually the document is wrong about module support, the default is off: > > These issues are independent of this patch, but... > >> >

Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules option

2015-11-03 Thread Daniel P. Berrange
On Tue, Nov 03, 2015 at 11:22:13AM +, Stefan Hajnoczi wrote: > On Tue, Nov 03, 2015 at 08:24:47AM +0800, Fam Zheng wrote: > > On Mon, 11/02 14:06, Stefan Hajnoczi wrote: > > Actually the document is wrong about module support, the default is off: > > These issues are independent of this patch,

Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules option

2015-11-03 Thread Stefan Hajnoczi
On Tue, Nov 03, 2015 at 08:24:47AM +0800, Fam Zheng wrote: > On Mon, 11/02 14:06, Stefan Hajnoczi wrote: > Actually the document is wrong about module support, the default is off: These issues are independent of this patch, but... > > Optional features, enabled with --enable-FEATURE and > > disab

Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules option

2015-11-02 Thread Fam Zheng
On Mon, 11/02 14:06, Stefan Hajnoczi wrote: > According to ./configure all options should have both --enable-foo and > --disable-foo: > > # Always add --enable-foo and --disable-foo command line args. > # Distributions want to ensure that several features are compiled in, and it > # is impos

[Qemu-devel] [PATCH] configure: add missing --disable-modules option

2015-11-02 Thread Stefan Hajnoczi
According to ./configure all options should have both --enable-foo and --disable-foo: # Always add --enable-foo and --disable-foo command line args. # Distributions want to ensure that several features are compiled in, and it # is impossible without a --enable-foo that exits if a feature is