Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Marcelo Tosatti
On Thu, Aug 02, 2012 at 05:53:37PM +0200, Alexander Graf wrote: > > On 02.08.2012, at 17:46, Andreas Färber wrote: > > > Am 02.08.2012 17:41, schrieb Peter Maydell: > >> Ping? > > > > Alex? Christian? > > Looks good to me, and should probably go in through the kvm queue. Avi, > Marcelo? Sure,

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Andreas Färber
Am 02.08.2012 18:22, schrieb Peter Maydell: > On 2 August 2012 17:01, Andreas Färber wrote: >> One minor nit: The indentation seems off here - esac 2 spaces, if 4. > > configure's indentation is pretty inconsistent generally between > 2 or 4 spaces. I usually go for 4 for new code but don't reind

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Peter Maydell
On 2 August 2012 17:01, Andreas Färber wrote: > One minor nit: The indentation seems off here - esac 2 spaces, if 4. configure's indentation is pretty inconsistent generally between 2 or 4 spaces. I usually go for 4 for new code but don't reindent old code. (There's a lot more 2-space than 4-spac

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Andreas Färber
Am 18.07.2012 13:10, schrieb Peter Maydell: > The code creating the symlink from linux-headers/asm to the > architecture specific linux-headers/asm-$arch directory was > implicitly hardcoding a list of KVM supporting architectures. > Add a default case for the common "Linux architecture name and >

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Alexander Graf
On 02.08.2012, at 17:46, Andreas Färber wrote: > Am 02.08.2012 17:41, schrieb Peter Maydell: >> Ping? > > Alex? Christian? Looks good to me, and should probably go in through the kvm queue. Avi, Marcelo? > >> >> -- PMM >> >> On 18 July 2012 12:10, Peter Maydell wrote: >>> The code creating

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Andreas Färber
Am 02.08.2012 17:41, schrieb Peter Maydell: > Ping? Alex? Christian? > > -- PMM > > On 18 July 2012 12:10, Peter Maydell wrote: >> The code creating the symlink from linux-headers/asm to the >> architecture specific linux-headers/asm-$arch directory was >> implicitly hardcoding a list of KVM s

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Peter Maydell
Ping? -- PMM On 18 July 2012 12:10, Peter Maydell wrote: > The code creating the symlink from linux-headers/asm to the > architecture specific linux-headers/asm-$arch directory was > implicitly hardcoding a list of KVM supporting architectures. > Add a default case for the common "Linux architec

[Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-07-18 Thread Peter Maydell
The code creating the symlink from linux-headers/asm to the architecture specific linux-headers/asm-$arch directory was implicitly hardcoding a list of KVM supporting architectures. Add a default case for the common "Linux architecture name and QEMU CPU name match" case, so future architectures wil