Re: [Qemu-devel] [PATCH] checkpatch: remove rule on non-indented labels

2011-11-01 Thread Anthony Liguori
On 10/07/2011 08:59 AM, Paolo Bonzini wrote: There are 508 non-indented (non-default) labels, and 511 that are indented. So the rule is debatable at least. Actually, in the common case of labels at the outermost scope, there is really just one place where to put the label, so the rule is just w

Re: [Qemu-devel] [PATCH] checkpatch: remove rule on non-indented labels

2011-10-07 Thread Peter Maydell
On 7 October 2011 14:59, Paolo Bonzini wrote: > There are 508 non-indented (non-default) labels, and 511 that are > indented.  So the rule is debatable at least.  Actually, in the > common case of labels at the outermost scope, there is really just > one place where to put the label, so the rule i

[Qemu-devel] [PATCH] checkpatch: remove rule on non-indented labels

2011-10-07 Thread Paolo Bonzini
There are 508 non-indented (non-default) labels, and 511 that are indented. So the rule is debatable at least. Actually, in the common case of labels at the outermost scope, there is really just one place where to put the label, so the rule is just wrong IMHO. Signed-off-by: Paolo Bonzini ---