Re: [Qemu-devel] [PATCH] chardev: fix pty_chr_timer

2013-08-30 Thread Gerd Hoffmann
On Do, 2013-08-22 at 11:57 +0200, Gerd Hoffmann wrote: > pty_chr_timer first calls pty_chr_update_read_handler(), then clears > timer_tag (because it is a one-shot timer). This is the wrong order > though. pty_chr_update_read_handler might re-arm time timer, and the > new timer_tag gets overwitt

Re: [Qemu-devel] [PATCH] chardev: fix pty_chr_timer

2013-08-22 Thread Laszlo Ersek
On 08/22/13 11:57, Gerd Hoffmann wrote: > pty_chr_timer first calls pty_chr_update_read_handler(), then clears > timer_tag (because it is a one-shot timer). This is the wrong order > though. pty_chr_update_read_handler might re-arm time timer, and the > new timer_tag gets overwitten in that case

[Qemu-devel] [PATCH] chardev: fix pty_chr_timer

2013-08-22 Thread Gerd Hoffmann
pty_chr_timer first calls pty_chr_update_read_handler(), then clears timer_tag (because it is a one-shot timer). This is the wrong order though. pty_chr_update_read_handler might re-arm time timer, and the new timer_tag gets overwitten in that case. This leads to crashes when unplugging a pty c