Re: [Qemu-devel] [PATCH] char: fix missing return in error path for chardev TLS init

2016-10-08 Thread Michael Tokarev
30.09.2016 18:02, Daniel P. Berrange wrote: If the qio_channel_tls_new_(server|client) methods fail, we disconnect the client. Unfortunately a missing return means we then go on to try and run the TLS handshake on a NULL I/O channel. This gives predictably segfaulty results. Applied to -trivial

Re: [Qemu-devel] [PATCH] char: fix missing return in error path for chardev TLS init

2016-09-30 Thread Eric Blake
On 09/30/2016 10:02 AM, Daniel P. Berrange wrote: > If the qio_channel_tls_new_(server|client) methods fail, > we disconnect the client. Unfortunately a missing return > means we then go on to try and run the TLS handshake on > a NULL I/O channel. This gives predictably segfaulty > results. > > Th

[Qemu-devel] [PATCH] char: fix missing return in error path for chardev TLS init

2016-09-30 Thread Daniel P. Berrange
If the qio_channel_tls_new_(server|client) methods fail, we disconnect the client. Unfortunately a missing return means we then go on to try and run the TLS handshake on a NULL I/O channel. This gives predictably segfaulty results. The main way to trigger this is to request a bogus TLS priority st