Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper

2013-11-14 Thread Avi Kivity
On 11/14/2013 03:29 PM, Stefan Hajnoczi wrote: On Tue, Nov 12, 2013 at 01:10:24PM +0200, Avi Kivity wrote: Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper since it doesn't have the required capabilities. Fix by adding them. Up until now, downstreams had to make the bridge

Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper

2013-11-14 Thread Stefan Hajnoczi
On Tue, Nov 12, 2013 at 01:10:24PM +0200, Avi Kivity wrote: > Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper since > it doesn't have the required capabilities. > > Fix by adding them. Up until now, downstreams had to make the bridge helper executable setuid, add the cap_net

Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper

2013-11-12 Thread Avi Kivity
On Nov 12, 2013 9:23 PM, "Eric Blake" wrote: > > On 11/12/2013 04:10 AM, Avi Kivity wrote: > > Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper since > > it doesn't have the required capabilities. > > > > Fix by adding them. > > > > Note: this may break installing as non-root.

Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper

2013-11-12 Thread Eric Blake
On 11/12/2013 04:10 AM, Avi Kivity wrote: > Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper since > it doesn't have the required capabilities. > > Fix by adding them. > > Note: this may break installing as non-root. This is actually the right > thing to do, since not settin

[Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper

2013-11-12 Thread Avi Kivity
Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper since it doesn't have the required capabilities. Fix by adding them. Note: this may break installing as non-root. This is actually the right thing to do, since not setting up the capability would result in a broken setup. Per