Re: [Qemu-devel] [PATCH] build: Add include check on syscall.h

2016-01-29 Thread Lluís Vilanova
Peter Maydell writes: > On 29 January 2016 at 13:30, Lluís Vilanova wrote: >> Peter Maydell writes: >>> Adding include guards is fine, but it sounds to me like what we >>> should actually do to fix this confusion is rename all the linux-user >>> local headers to target_syscall.h. >> >> Hmmm, I d

Re: [Qemu-devel] [PATCH] build: Add include check on syscall.h

2016-01-29 Thread Peter Maydell
On 29 January 2016 at 13:30, Lluís Vilanova wrote: > Peter Maydell writes: >> Adding include guards is fine, but it sounds to me like what we >> should actually do to fix this confusion is rename all the linux-user >> local headers to target_syscall.h. > > Hmmm, I didn't know if using the same nam

Re: [Qemu-devel] [PATCH] build: Add include check on syscall.h

2016-01-29 Thread Lluís Vilanova
Peter Maydell writes: > On 28 January 2016 at 20:36, Lluís Vilanova wrote: >> The LTTng tracing backend includes the system's "syscall.h", but QEMU >> replaces it with its own for linux-user builds. This results in a double >> include on some targets (when LTTng is enabled). >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH] build: Add include check on syscall.h

2016-01-29 Thread Peter Maydell
On 28 January 2016 at 20:36, Lluís Vilanova wrote: > The LTTng tracing backend includes the system's "syscall.h", but QEMU > replaces it with its own for linux-user builds. This results in a double > include on some targets (when LTTng is enabled). > > Signed-off-by: Lluís Vilanova Adding includ

[Qemu-devel] [PATCH] build: Add include check on syscall.h

2016-01-28 Thread Lluís Vilanova
The LTTng tracing backend includes the system's "syscall.h", but QEMU replaces it with its own for linux-user builds. This results in a double include on some targets (when LTTng is enabled). Signed-off-by: Lluís Vilanova --- linux-user/aarch64/syscall.h |5 + linux-user/alpha/syscall.h